fix(Nodes): support v2 compute #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jul 17, 2023
Comment on lines
64
to
67
| export enum EVersion { | ||
| v1, | ||
| v2, // only this versions works with sorting | ||
| v1 = 'v1', | ||
| v2 = 'v2', // only this versions works with sorting | ||
| } |
There was a problem hiding this comment.
Enums if this format (enum EVersion { v1 }) have numbers as values (EVersion.v1 === 0). So I added string values to all enums, where they was missing
artemmufazalov
force-pushed
the
support-v2-compute
branch
from
08ef726
to
10169c3
Compare
Raubzeug
approved these changes
Jul 18, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.