feat: update TenantOverview design #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krosy1337
commented
Aug 29, 2023
krosy1337
commented
krosy1337
force-pushed
the
add-four-cards
branch
5 times, most recently
from
aaa156c
to
a2de177
Compare
krosy1337
force-pushed
the
add-four-cards
branch
from
a2de177
to
1fe0737
Compare
Raubzeug
requested changes
Sep 5, 2023
src/containers/Tenant/Diagnostics/DetailedOverview/DetailedOverview.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| transition: color 0.1s; | ||
|
|
||
| &_selected { |
There was a problem hiding this comment.
I suggest to keep all styles related with selected state in one place, in this file. Because you select a card in whole, not it's components. So lets pass not selected to CircularProgressBar but className, which styles will be defined here.
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.scss
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,6 @@ | |||
| .metrics-cards { | |||
| display: flex; | |||
There was a problem hiding this comment.
Don't you want to wrap cards to another line if container's width is not enough?
artemmufazalov
requested changes
Sep 6, 2023
src/containers/Tenant/Diagnostics/TenantOverview/MetricsCards/MetricsCards.tsx
Outdated
Show resolved
Hide resolved
krosy1337
force-pushed
the
add-four-cards
branch
from
4df8e17
to
3fc3294
Compare
krosy1337
force-pushed
the
add-four-cards
branch
from
3fc3294
to
aa45e7a
Compare
Raubzeug
reviewed
Sep 8, 2023
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx
Outdated
Show resolved
Hide resolved
krosy1337
force-pushed
the
add-four-cards
branch
from
21e01f8
to
495a7c7
Compare
Raubzeug
requested changes
Sep 12, 2023
src/containers/Tenant/Diagnostics/Healthcheck/Preview/Preview.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/Healthcheck/Preview/Preview.tsx
Outdated
Show resolved
Hide resolved
Raubzeug
previously approved these changes
Sep 12, 2023
artemmufazalov
previously approved these changes
Sep 12, 2023
krosy1337
dismissed stale reviews from artemmufazalov and Raubzeug
via
b6380ab
artemmufazalov
approved these changes
Sep 13, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.