-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update TenantOverview design #527
Conversation
krosy1337
commented
Aug 29, 2023
aaa156c
to
a2de177
Compare
a2de177
to
1fe0737
Compare
src/containers/Tenant/Diagnostics/DetailedOverview/DetailedOverview.tsx
Outdated
Show resolved
Hide resolved
|
||
transition: color 0.1s; | ||
|
||
&_selected { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to keep all styles related with selected
state in one place, in this file. Because you select a card in whole, not it's components. So lets pass not selected
to CircularProgressBar
but className
, which styles will be defined here.
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.scss
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,6 @@ | |||
.metrics-cards { | |||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you want to wrap cards to another line if container's width is not enough?
src/containers/Tenant/Diagnostics/TenantOverview/MetricsCards/MetricsCards.tsx
Outdated
Show resolved
Hide resolved
4df8e17
to
3fc3294
Compare
3fc3294
to
aa45e7a
Compare
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx
Outdated
Show resolved
Hide resolved
21e01f8
to
495a7c7
Compare
src/containers/Tenant/Diagnostics/Healthcheck/Preview/Preview.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/Healthcheck/Preview/Preview.tsx
Outdated
Show resolved
Hide resolved
b6380ab