fix(QueryResultTable): fix table error on null cell sort #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewer/json/query
returnsnull
for empty table cells.If type of table value was 'object', it was converted to string. But
typeof null === 'object'
.Check
if (value === null)
didn't work becausenull
was a string. However, when passed toBigInt
, it was further converted that caused an error, table was stuck in invalid state.Because of this issue sorting in
Preview
table could lead toSyntaxError
(displayed on the screen).To fix it, I prevent converting
null
to string, when data is initially parsed.