fix(QueryResultTable): fix table error on null cell sort #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Nov 16, 2023
| return columnType === 'number' ? BigInt(value) : value; | ||
| }, | ||
| render: ({value}) => <Cell value={value as string} />, | ||
| render: ({row}) => <Cell value={String(row[name])} />, |
There was a problem hiding this comment.
value type is always unknown. So I extract value from typed row value
Raubzeug
approved these changes
Nov 16, 2023
artemmufazalov
force-pushed
the
fix-preview-table-sort
branch
from
485953c
to
f257b28
Compare
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewer/json/queryreturnsnullfor empty table cells.If type of table value was 'object', it was converted to string. But
typeof null === 'object'.Check
if (value === null)didn't work becausenullwas a string. However, when passed toBigInt, it was further converted that caused an error, table was stuck in invalid state.Because of this issue sorting in
Previewtable could lead toSyntaxError(displayed on the screen).To fix it, I prevent converting
nullto string, when data is initially parsed.