feat(TenantOverview): add columns to memory table #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Nov 21, 2023
Comment on lines
+69
to
+78
| /** | ||
| * int64 | ||
| * | ||
| * a positive value means the peer is ahead in time; a negative value means it's behind | ||
| */ | ||
| MaxClockSkewWithPeerUs?: string; | ||
| MaxClockSkewPeerId?: number; | ||
|
|
||
| /** uint64 */ | ||
| DisconnectTime?: string; |
There was a problem hiding this comment.
Values that are new in backend proto file. They received from backend, but are not used in current PR. Added to interface to keep it relevant
artemmufazalov
force-pushed
the
update-memory-table
branch
from
c00b53a
to
96d8f71
Compare
artemmufazalov
commented
Nov 21, 2023
| colorizeProgress={true} | ||
| /> | ||
| ) : ( | ||
| '—' |
There was a problem hiding this comment.
No data progress bar is more explicit than dash and suits more to neighbour cells and columns.
Raubzeug
approved these changes
Nov 22, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add columns
Tablet Cache,Query RuntimeandSessionsExample 1 (version before tablet cache and sessions were added to response)
Example 2 (current version, but with small usage)
