feat: always use localStorage if no settingsApi #603
Conversation
| window.api.postSetting(name, value); | ||
| } else { | ||
| localStorage.setItem(name, value); |
There was a problem hiding this comment.
Potentially this operation may fail, sp lets wrap it with try ... catch.
There was a problem hiding this comment.
What should be in catch section in this case?
| @@ -3,8 +3,11 @@ import {getValueFromLS} from './utils'; | |||
| export const userSettings = window.userSettings || {}; | |||
| export const systemSettings = window.systemSettings || {}; | |||
|
|
|||
| export const settingsApi = window.web_version ? systemSettings.settingsApi : undefined; | |||
There was a problem hiding this comment.
What if we define settingsApi ourselves if it isn't defined initially? We know methods it should provide and can define it. Thus in other code there will be no need to worry, just use settingsApi.
There was a problem hiding this comment.
Could you please clarify you question? I didn't get it
If you mean changing settingsApi on a go, this case isn't supported. The problem is that when we declare new settingsApi by ourselves, all currently stored settings should be copied there. Otherwise, there will be scenario, where our settings partly stored in localStorage, partly in other store, it will be a mess.
If you mean incapsulating this logic into some instance, that will provide certain API and decide where to store data within itself, I don't think it's really needed. The problem, that I solve here, is that we want to use localStorage both in internal and in embedded version. Now it will be a migration period, after which settingsApi will be deleted
Currently, it's first iteration to allow UI usage in Nebius, where there is no special backend service for user settings. After that I add some migration to code, that will copy data from settingsApi to localStorage. And as final step, use only localStorage
There was a problem hiding this comment.
Ok, I've got it! Lets stick to current version!
If no
settingsApiis provided, app should always uselocalStorage