Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend storage handler response - add media_type field #647

Closed
artemmufazalov opened this issue Jan 15, 2024 · 5 comments
Closed

Extend storage handler response - add media_type field #647

artemmufazalov opened this issue Jan 15, 2024 · 5 comments
Assignees
Labels
🐞 type/bug Something isn't working

Comments

@artemmufazalov
Copy link
Member

artemmufazalov commented Jan 15, 2024

Currently v2 storage response contains long full disk types

They should be converted to HDD, SSD if this substrings are present

Image

Let's use type property

      storage_pool_types:
      - kind: /Root:ssd_1
        pool_config:
          box_id: '1'
          erasure_species: block-4-2
          kind: /Root:ssd_1
          pdisk_filter:
          - property:
            - type: SSD
@antonkovalenko
Copy link
Member

I there's a special field (media kind?) that contains hdd or rot and ssd despite the pool name

@artemmufazalov
Copy link
Member Author

The content of this field is on screen.

Actually, on backend there is some logic, that properly determines disk type. It's in v1 storage. So it's should be just applied for v2 storage as well

@StekPerepolnen

@antonkovalenko antonkovalenko added the 🐞 type/bug Something isn't working label Feb 22, 2024
@StekPerepolnen
Copy link

@artemmufazalov could you please clarify ydb version where /Root:hdd_1 was noticed? I've just checked this issue on trunk and ydb-stable-23-3-28 - both versions return equal value (like hdd)

@artemmufazalov
Copy link
Member Author

@artemmufazalov could you please clarify ydb version where /Root:hdd_1 was noticed? I've just checked this issue on trunk and ydb-stable-23-3-28 - both versions return equal value (like hdd)

It depends on cluster - on some clusters types are correct.

Versions, where I found this bug: ydb-stable-23-3-26, ydb-stable-23-4-3,

@antonkovalenko antonkovalenko changed the title Convert storage v2 disk types to uppercase short format Extend storage handler response - add pdisk_mdeia_type field Feb 28, 2024
@antonkovalenko antonkovalenko changed the title Extend storage handler response - add pdisk_mdeia_type field Extend storage handler response - add media_type field Feb 28, 2024
@StekPerepolnen
Copy link

StekPerepolnen commented Mar 4, 2024

ydb-platform/ydb#2441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants