Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to uikit 6 #789

Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat!: update to uikit 6 #789

merged 4 commits into from
Apr 10, 2024

Conversation

ValeraS
Copy link
Collaborator

@ValeraS ValeraS commented Apr 2, 2024

Closes #790, closes #650

src/.eslintrc Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataTable columns initially stick to left, they blink on load, Skeleton isn’t shown

src/containers/Tenant/Schema/SchemaTree/SchemaTree.tsx Outdated Show resolved Hide resolved
src/containers/Tenant/Diagnostics/Diagnostics.tsx Outdated Show resolved Hide resolved
@artemmufazalov
Copy link
Member

Please, split such PRs apart in the future, GitHub cannot do normal virtualisation, everything lags (it renders 150k DOM elements on first load and 250k when diffs are loaded). So I cannot event leave a comment without waiting for some time

@ValeraS
Copy link
Collaborator Author

ValeraS commented Apr 2, 2024

Please, split such PRs apart in the future, GitHub cannot do normal virtualisation, everything lags (it renders 150k DOM elements on first load and 250k when diffs are loaded). So I cannot event leave a comment without waiting for some time

image

You can view and comment changes locally or in a codespace.

@artemmufazalov
Copy link
Member

Please, set sortable={false} to both TableColumnSetup, columns reordering isn't supported

@artemmufazalov
Copy link
Member

Some button name is needed

image

@ValeraS ValeraS merged commit 1a3154d into main Apr 10, 2024
4 checks passed
@ValeraS ValeraS deleted the feat/uikit6 branch April 10, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refresh dependencies Update prettier, eslint and stylelint
2 participants