fix: fix copy button not hidden after copy #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested changes
May 22, 2024
| @@ -119,8 +119,7 @@ body, | |||
| .data-table__row, | |||
| .ydb-virtual-table__row, | |||
| .ydb-tree-view__item { | |||
| &:hover, | |||
| &:focus-within { | |||
| &:hover { | |||
There was a problem hiding this comment.
let's add focus-visible here, to make the button visible if iterating with keyboard.
There was a problem hiding this comment.
Elements with visibility:hidden cannot be selected with tab, so it doesn't have any effect
There was a problem hiding this comment.
100%! What do you think if we hide them with opacity=0?
There was a problem hiding this comment.
opacity=0 works just fine, updated PR
Raubzeug
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy button didn't hide after copy. Made it be shown only on hover
Test stand: https://nda.ya.ru/t/01pCgQBZ763DPX