Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RepeatedProc to Repeated and move to func or proc package #1409

Closed
fabriciofx opened this issue Jul 4, 2020 · 6 comments
Closed

Rename RepeatedProc to Repeated and move to func or proc package #1409

fabriciofx opened this issue Jul 4, 2020 · 6 comments

Comments

@fabriciofx
Copy link
Contributor

To me seems RepeatedProc has two problems:

  1. It's in the wrong package (org.cactoos). and it should be in org.cactoos.func or org.cactoos.proc package

  2. It's a decorator, so should be renamed to Repeated

@victornoel WDYT?

@0crat
Copy link
Collaborator

0crat commented Jul 4, 2020

@paulodamaso/z, @victornoel/z please, pay attention to this issue

@victornoel
Copy link
Collaborator

@fabriciofx yes, let's tackle that simply as part of #1406

@fabriciofx
Copy link
Contributor Author

@victornoel I'll wait for finish #1406 to close this ticket, ok?

@victornoel
Copy link
Collaborator

@fabriciofx I think it's ok to close it right now, but feel free to track it and close it when it is actually fixed if you want :)

@fabriciofx
Copy link
Contributor Author

@victornoel I agree. I'll close it now. Thanks!

@0crat
Copy link
Collaborator

0crat commented Jul 6, 2020

Job gh:yegor256/cactoos#1409 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants