Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absence of 404s confuses maven #324

Open
amr opened this issue Mar 2, 2016 · 5 comments
Open

Absence of 404s confuses maven #324

amr opened this issue Mar 2, 2016 · 5 comments
Labels
30 mins bug DEV
Milestone
1.0

Comments

@amr
Copy link

amr commented Mar 2, 2016

Hi,

I'm using s3auth to power my private maven repo. It's working great, except that maven often tries to lookup central artifacts in the private s3auth-powered repo, and due to the directory listing feature which returns 200 OK instead of 404 Not Found, maven thinks that it has retrieved the correct file.

Therefore, inspecting the contents of the retrieved JAR file with:

cat ~/.m2/repository/org/springframework/data/spring-data-elasticsearch/1.3.4.RELEASE/spring-data-elasticsearch-1.3.4.RELEASE-sources.jar

Yields:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<html xmlns="http://www.w3.org/1999/xhtml" lang="en">
<head>
  <meta charset="UTF-8"/>
  <link href="http://www.s3auth.com/css/layout.css" media="all" rel="stylesheet" type="text/css"/>
</head>
<body>
<div id="content">
  <p>This is page is auto-generated by s3auth.com</p>
  <p style="margin-bottom: 2em;">prefix: 
      <span class="tt">release/org/springframework/data/spring-data-elasticsearch/1.3.4.RELEASE/spring-data-elasticsearch-1.3.4.RELEASE-sources.jar/</span>
  </p>
  <table>
    <tr style="text-align: left;">
      <th>Name</th>
      <th>Size (bytes)</th>
    </tr>
  </table>
</div>
</body>
</html>`

I believe the minimal change which preserves the feature as is to keep the directory listing result as is, but with an HTTP status code of 404. Will keep everyone happy.
@davvd
Copy link

davvd commented Mar 7, 2016

@yegor256 please take a look at it and dispatch (see par.21)

@yegor256
Copy link
Owner

@amr sounds reasonable, thanks, we'll implement this

@yegor256 yegor256 added the bug label Mar 11, 2016
@davvd davvd added this to the 1.0 milestone Mar 11, 2016
@davvd
Copy link

davvd commented Mar 11, 2016

@amr I set the milestone to 1.0 since there is nothing set yet

@yegor256
Copy link
Owner

@amr I'm sorry this bug is still not fixed. We didn't have enough funds/time to work on the project. However, recently we received some donations from our grateful users and will continue to fix issues and introduce new features. Would be great if you can also donate -- to help us move forward faster. Here is the link: https://www.0crat.com/contrib/C3RP1J1CH

@alexbird
Copy link

FYI I suspect this is also stopping git cloning a bare repo from S3 – this is a repo simply used to host Cocoapod spec files. I am hosting a private library for both Android and iOS, but have not had an issue with Maven so far.

fatal: http://[repo path]/info/refs not valid: is this a git repository? there is no refs file or folder so this should ideally be a 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins bug DEV
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@amr @yegor256 @alexbird @davvd