Coverage should exclude the template folder

[SBoudrias]

Title is pretty self explicit. We don't want to cover JS files inside the template folder.

[udnisap]

does it include?

[SBoudrias]

@udnisap sorry, what do you mean?

[udnisap]

I am assuming you are referring to coverage.io reports.
https://coveralls.io/builds/4282602
there are no templates

[SBoudrias]

Oh, I'm talking about the generated code. I removed template coverage manually from this repository, but the generated code still covers the template folder.

[hemanth]

It should be done at gulp-task?
gulp-coverall doesn't provide any options to skip files.

[SBoudrias]

in the pre-test tasks.

[hemanth]

Just a '!**/templates/**' is the src is fine?

Well, I see specific files being mentioned in the src, no glob.

[SBoudrias]

In the generated code, not the project code.

[hemanth]

Ha ok, this change must be in 'node:app' right?

[udnisap]

Generate app has 100% coverage

[eddiemonge]

Ha ok, this change must be in 'node:app' right?

I think this sounds right. Should this be closed here and opened there? https://github.com/yeoman/generator-node/issues/new

[SBoudrias]

It'd probably require some changes on both sides, so we should keep it open here and figure how we want to pass that to generator-node (probably a new option).