Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

html comments inside build block #144

Closed
vitalets opened this issue Jul 12, 2013 · 5 comments
Closed

html comments inside build block #144

vitalets opened this issue Jul 12, 2013 · 5 comments

Comments

@vitalets
Copy link

I've commented some script tags inside build:js block, but still getting commented files (main.js) in concat:

    <!-- build:js all.min.js -->
    <script src="scripts/app.js"></script>
    <!-- <script src="scripts/controllers/main.js"></script> -->
    <!-- endbuild -->

is it a bug, or I'm doing something wrong?

@eddiemonge
Copy link
Member

this is somewhat similar to #137

@kylecordes
Copy link

This also looks similar to the problem with HTML that is not written line-by-line; to produce correct results for a wide array of cases, usemin needs to operate at the HTML structure level, which would also solve this problem.

@davidpustai
Copy link

Have the same problem. I have commented list of Foundation modules <script> tags and although they are all inside a comment, they are still being concat'ed. Of course I can place the tag before those commented lines, but it's kinda hack and doesn't allow me to uncomment the modules that I just want to use.

@robwierzbowski
Copy link

...operate at the HTML structure level, which would also solve this problem.

@kylecordes, if you're interested in contributing / adding thoughts, there's an open issue here: #244

@SimplGy
Copy link

SimplGy commented Jul 30, 2014

This caused a surprising build-only issue for us. Makes sense when you understand that the tool operates only using regex, but It's an easy mistake to make: "Oh, we might not want this library, let me comment it out".

Nope. Whammo: stitchmin-only issue, and those are the worst.

Careful y'all: Don't comment out script tags inside your usemin block, it will bite you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants