-
Notifications
You must be signed in to change notification settings - Fork 339
html comments inside build block #144
Comments
this is somewhat similar to #137 |
This also looks similar to the problem with HTML that is not written line-by-line; to produce correct results for a wide array of cases, usemin needs to operate at the HTML structure level, which would also solve this problem. |
Have the same problem. I have commented list of Foundation modules <script> tags and although they are all inside a comment, they are still being concat'ed. Of course I can place the tag before those commented lines, but it's kinda hack and doesn't allow me to uncomment the modules that I just want to use. |
@kylecordes, if you're interested in contributing / adding thoughts, there's an open issue here: #244 |
This caused a surprising build-only issue for us. Makes sense when you understand that the tool operates only using regex, but It's an easy mistake to make: "Oh, we might not want this library, let me comment it out". Nope. Whammo: stitchmin-only issue, and those are the worst. Careful y'all: Don't comment out script tags inside your usemin block, it will bite you. |
I've commented some script tags inside build:js block, but still getting commented files (main.js) in concat:
is it a bug, or I'm doing something wrong?
The text was updated successfully, but these errors were encountered: