-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filetypes gone after building #16
Comments
We've run into this as well and after some testing, it seems like it is because this Action invokes the command like this:
The
In this case, it'd run The Godot docs sound like the ending should be appended automatically when exporting like this, so maybe that's where this issue comes from. Elsewhere in the docs, however, the ending is included in this name parameter. Either way, it might be helpful to add an option which does not include any name override and just uses the name configured in the preset. |
This is easily fixed by adding some extra fields in the matrix. Here's an example config: name: Build Godot
on:
push: {}
pull_request: {}
jobs:
Godot:
runs-on: ubuntu-latest
strategy:
matrix:
platform:
- name: Windows
file: game.exe
- name: MacOS
file: game.zip
- name: Linux
file: game
steps:
- uses: actions/checkout@v2
- name: Build
id: build
uses: manleydev/[email protected]
with:
name: ${{ matrix.platform.file }}
preset: ${{ matrix.platform.name }}
debugMode: false
- name: Upload Artifact
uses: actions/upload-artifact@v2
with:
name: Game - ${{ matrix.platform.name }}
path: ${{ github.workspace }}/${{ steps.build.outputs.build }} Edit: Fixed MacOS file extension for anyone googling for a solution. |
The suffix to use for macOS exporting is |
@Calinou Ah, so for MacOS binaries, the following applies:
|
Yes, although you can still use the |
Hello, when I'm building the project on my machine it works for Windows and Mac, but when using your tool, the filetypes are gone. For Windows, I can just add .exe behind it, and it works, but for Mac, adding .app behind it does not work. Am I doing something wrong here?
The text was updated successfully, but these errors were encountered: