Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filetypes gone after building #16

Open
lreinink opened this issue Mar 16, 2021 · 5 comments
Open

Filetypes gone after building #16

lreinink opened this issue Mar 16, 2021 · 5 comments

Comments

@lreinink
Copy link

Hello, when I'm building the project on my machine it works for Windows and Mac, but when using your tool, the filetypes are gone. For Windows, I can just add .exe behind it, and it works, but for Mac, adding .app behind it does not work. Am I doing something wrong here?

@kb173
Copy link

kb173 commented Jan 16, 2022

We've run into this as well and after some testing, it seems like it is because this Action invokes the command like this:

godot --export "platform" name

The name specifies the filename of the exported file, and it comes from what's written in your Action yml, e.g.:

        with:
          name: my-game

In this case, it'd run godot --export "platform" my-game, and this my-game overrides the name from the export preset which presumably has the correct ending.

The Godot docs sound like the ending should be appended automatically when exporting like this, so maybe that's where this issue comes from. Elsewhere in the docs, however, the ending is included in this name parameter.

Either way, it might be helpful to add an option which does not include any name override and just uses the name configured in the preset.

@semirix
Copy link

semirix commented May 26, 2022

This is easily fixed by adding some extra fields in the matrix. Here's an example config:

name: Build Godot

on:
  push: {}
  pull_request: {}

jobs:
  Godot:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        platform:
        - name: Windows
          file: game.exe
        - name: MacOS
          file: game.zip
        - name: Linux
          file: game
    steps:
      - uses: actions/checkout@v2
      - name: Build
        id: build
        uses: manleydev/[email protected]
        with:
          name: ${{ matrix.platform.file }}
          preset: ${{ matrix.platform.name }}
          debugMode: false
      - name: Upload Artifact
        uses: actions/upload-artifact@v2
        with:
          name: Game - ${{ matrix.platform.name }}
          path: ${{ github.workspace }}/${{ steps.build.outputs.build }}

Edit: Fixed MacOS file extension for anyone googling for a solution.

@Calinou
Copy link

Calinou commented May 26, 2022

For Windows, I can just add .exe behind it, and it works, but for Mac, adding .app behind it does not work. Am I doing something wrong here?

The suffix to use for macOS exporting is .zip or .dmg. .app can't be used directly (although an .app is contained within the generated ZIP).

@semirix
Copy link

semirix commented May 27, 2022

The suffix to use for macOS exporting is .zip or .dmg. .app can't be used directly (although an .app is contained within the generated ZIP).

@Calinou Ah, so for MacOS binaries, the following applies:

OS Used to Export Resulting File for Mac Binary
Linux .zip
Windows .zip
MacOS .dmg

@Calinou
Copy link

Calinou commented May 27, 2022

@Calinou Ah, so for MacOS binaries, the following applies:
OS Used to Export Resulting File for Mac Binary
Linux .zip
Windows .zip
MacOS .dmg

Yes, although you can still use the .zip target when exporting from macOS (it can do both .zip and .dmg).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants