From ad29228f10a1906f73a1ca3a109cd76573c761b2 Mon Sep 17 00:00:00 2001 From: salehhashemi1992 <81674631+salehhashemi1992@users.noreply.github.com> Date: Wed, 1 Nov 2023 12:12:32 +0330 Subject: [PATCH] refactor findBetween method to remove calling function mb_substr() --- src/StringHelper.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/StringHelper.php b/src/StringHelper.php index 3dde95f..39f6d2b 100644 --- a/src/StringHelper.php +++ b/src/StringHelper.php @@ -637,15 +637,14 @@ public static function findBetween(string $string, string $start, string $end): return null; } - // Cut the string from the start position - $subString = mb_substr($string, $startPos + mb_strlen($start)); - $endPos = mb_strrpos($subString, $end); + $startPos += mb_strlen($start); + $endPos = mb_strrpos($string, $end, $startPos); if ($endPos === false) { return null; } - return mb_substr($subString, 0, $endPos); + return mb_substr($string, $startPos, $endPos - $startPos); } /**