Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does prosemirrorToYXmlFragment really lose hystory? #147

Open
remorses opened this issue Oct 22, 2023 · 1 comment
Open

Does prosemirrorToYXmlFragment really lose hystory? #147

remorses opened this issue Oct 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@remorses
Copy link

remorses commented Oct 22, 2023

The prosemirrorToYXmlFragment documentation says "note that this function should not be used to rehydrate a Y.Doc from a database once collaboration has begun as all history will be lost"

But reading the code it doesn't look like the yjs doc history is being lost, it seems it applies any update from the prosemirror node to the yjs doc, am i right?

export function prosemirrorToYXmlFragment (doc, xmlFragment) {

@remorses remorses added the bug Something isn't working label Oct 22, 2023
@websiddu
Copy link

websiddu commented Jan 2, 2024

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants