Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapper is 64-bit centric. Should it be? #256

Closed
vext01 opened this issue Feb 19, 2021 · 2 comments
Closed

Mapper is 64-bit centric. Should it be? #256

vext01 opened this issue Feb 19, 2021 · 2 comments

Comments

@vext01
Copy link
Contributor

vext01 commented Feb 19, 2021

As mentioned here the mapper uses a u64 type for addresses, which is incorrect for 32-bit architectures.

  • ELF addresses are either 32 or 64-bit unsigned.
  • PT addresses are always 64-bit. No 32-bit x86 architecture has PT to my knowledge.
  • The maper is PT-centric.
@vext01 vext01 mentioned this issue Feb 19, 2021
Closed
@vext01
Copy link
Contributor Author

vext01 commented Jun 24, 2021

This is, I believe, still true of the new LLVM-based yk design.

@ltratt
Copy link
Contributor

ltratt commented May 16, 2023

We fixed this at some point in the past.

@ltratt ltratt closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ltratt @vext01