-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting error with single quotes inside a string literal type #61
Comments
I would like to fix this bug |
@BalthazarB you're welcome to do it 🙂 |
Is this still open? |
@MikeJakuszewski yes |
@yoavbls, what is the expected behavior we want? Do we want to remove the inner quotes? I think I found the error, it is under format/addMissingParentheses.ts |
@MikeJakuszewski The expected behavior is without removing the inner quotes: You're welcome to try to fix it, and I can help in Discord if needed |
I'm pretty sure I fixed all the cases of string literal types that did not escape properly here. Give it a try with 0.5.2 and reopen this issue if you find new cases like this |
Describe the bug
Hovering over the error in:
The formatting is broken
Expected behavior
Original error
Type 'null' is not assignable to type '"' 'Oh no"'.ts(2322)
Screenshots
The text was updated successfully, but these errors were encountered: