Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dictionaries to specify minimum compatible Yomitan version #1506

Open
stephenmk opened this issue Oct 18, 2024 · 3 comments
Open

Allow dictionaries to specify minimum compatible Yomitan version #1506

stephenmk opened this issue Oct 18, 2024 · 3 comments
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@stephenmk
Copy link

On more than one occasion, I've had users report to me that they could not import Jitendex because they were using an older version of Yomitan.

If it were possible to specify a minimum Yomitan version in the dictionary's index.json metadata file, Yomitan could check the version and inform the user that they need to update Yomitan in order to use the dictionary.

@stephenmk stephenmk added the kind/enhancement The issue or PR is a new feature or request label Oct 18, 2024
@stephenmk
Copy link
Author

Noting that this was probably the purpose of having different schema versions, but those haven't been incremented since the yomichan days.

@Kuuuube
Copy link
Member

Kuuuube commented Oct 19, 2024

I think the schema versions are intended for breaking differences only. So if a change was made that broke backwards compatibility with older dicts.

Currently all dicts on the current schema version validate against the current schema just fine regardless of the age of the dict.

@stephenmk
Copy link
Author

I also get people asking me why my dictionary doesn't work in Jidoujisho, so something like a "minimum version" field would have been good to have a long time ago. But it would be better late than never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

No branches or pull requests

2 participants