Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primary_reading option for "dictionary deinflection" definition type #1507

Open
stephenmk opened this issue Oct 19, 2024 · 2 comments
Open
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@stephenmk
Copy link

Earlier this year, StefanVukovic99 informed me of a new definition type for supporting dictionary-level deinflections. Currently this syntax allows dictionary authors to redirect from a given term to a different term based upon a single query string. It would be convenient* if an additional primary_reading string could also be included with this redirect, similar to the internal link functionality implemented by khaitruong922 in pull request #1497

* For the dictionaries that I make, at least.

@stephenmk stephenmk added the kind/enhancement The issue or PR is a new feature or request label Oct 19, 2024
@stephenmk
Copy link
Author

stephenmk commented Oct 19, 2024

@khaitruong922 linked this issue to #1497, but I am actually describing a different feature that is not solved by that pull request.

With the way that deinflection definitions are currently designed, redirections are sometimes not sorted correctly. This could be fixed by allowing a priority_reading parameter to be included in the dictionary deinflection definition type.


For example, a search for 一かど pulls up the entry for いっかく on top instead of ひとかど.

Example: 一かど

hitokado


A search for ひと押し pulls up the entry for いちおし on top instead of ひとおし.

Example: ひと押し

hitooshi


A search for ひと文字 pulls up the entry for いちもじ on top instead of いちもじ.

Example: ひと文字

hitomoji

@stephenmk
Copy link
Author

Adding another example. A search for "ひでぇ" currently pulls up the entry for "むごい" before "ひどい"

Example: ひでぇ

hidee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

No branches or pull requests

1 participant