Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Support inputs for devices with touch screens" option and related code should be removed #466

Open
toasted-nutbread opened this issue Dec 27, 2023 · 2 comments · May be fixed by #1576
Open
Assignees

Comments

@toasted-nutbread
Copy link

All minimum browsers should support pointer events, and in general that should be preferred as it encompasses the other input types. At this point, having this option doesn't add anything useful, and time seems to have proved that it's working well. This would simplify some of the scanning code as well.

@toasted-nutbread toasted-nutbread self-assigned this Feb 11, 2024
@jamesmaa
Copy link
Collaborator

Yomitan should work on mobile and touch-screen devices without any configuration right? Maybe it's time to remove this. Thoughts?

@jamesmaa
Copy link
Collaborator

jamesmaa commented Nov 6, 2024

You're referring to this right?
image

@jamesmaa jamesmaa linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants