Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the pronunciation audio of the bigger word is not found, the audio of its sub-word should be played #575

Open
ganqqwerty opened this issue Jan 24, 2024 · 1 comment
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@ganqqwerty
Copy link

Pre-condition: the user turns on the option "Play audio automatically":
CleanShot 2024-01-24 at 15 12 54@2x

User calls yomita popup for a big word, for example 朝っぱらから. One of the dictionaries has an entry for the 朝っぱらから. However, no audio exists for 朝っぱらから.

CleanShot 2024-01-24 at 15 09 56@2x

There is a smaller word, 朝っぱら that is listed in the popup. The audio exists for this word.

My expectation is that yomitan should play the audio for 朝っぱら.

@ganqqwerty ganqqwerty added the kind/enhancement The issue or PR is a new feature or request label Jan 24, 2024
@ganqqwerty ganqqwerty changed the title If the pronunciation audio of the bigger word is not found, the pronunciation of its sub-word should be pronounced If the pronunciation audio of the bigger word is not found, the audio of its sub-word should be played Jan 26, 2024
@shiki-tm
Copy link

Screenshot_20241110_112836_Kiwi Browser
Screenshot_20241110_112727_Kiwi Browser
Screenshot_20241110_112537_Kiwi Browser
Screenshot_20241110_112420_Kiwi Browser

This is definitely a useful feature at least for japanese because since we got more and more dictionaries, they're great but also kinda show words with に,の,な,く and they usually don't have audio. Actually depending on your view you can say these are conjugations. So maybe it's something like described here #1579. I've always wanted this ability to just have it go down to the next word since these are clearly basically almost the same word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

No branches or pull requests

2 participants