Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry and retryBackoff in authorization webhook #194

Closed
2 tasks done
hackerwins opened this issue May 27, 2021 · 4 comments · Fixed by #212
Closed
2 tasks done

Implement retry and retryBackoff in authorization webhook #194

hackerwins opened this issue May 27, 2021 · 4 comments · Fixed by #212
Assignees
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers

Comments

@hackerwins
Copy link
Member

hackerwins commented May 27, 2021

What would you like to be added:

Why is this needed:

Authorizers can also be unstable, so we should retry it in a safe way.

@hackerwins hackerwins added enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers labels May 27, 2021
@dc7303
Copy link
Member

dc7303 commented Jul 2, 2021

@hackerwins Could I try this issue?

@hackerwins
Copy link
Member Author

Sure 👍

@dc7303
Copy link
Member

dc7303 commented Jul 8, 2021

@hackerwins I started designing to get this working. I have a few questions during this process.

  1. Is there a recommended maximum number of retries and maximum latency in mind? It would be nice to talk about this together. For example, the default maximum number of retries and maximum latency.
  2. I think would be good to talk about the options that can be input from the user, such as the maximum number of requests, whether to retry, the maximum waiting time, and timeout. Are you considering these options?

@hackerwins
Copy link
Member Author

Thank you for your question.

  1. I think appropriate values will be different for each environment to which it is applied. It would be nice to be able to create with default values and allow users to change them.
  2. How about implementing the basic structure first and extracting them one by one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants