-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GC for RHT Node #796
Comments
The case where the reference count becomes 0 is when the value corresponding to the existing key is overwritten in the process of In the case of |
This was fixed by #864. |
What would you like to be added:
Add a feature to RHT that allows the removal of attributes from elements
Currently, when performing Tree.RemoveStyle and calling RHT.Remove, the actual removal from the map is not performed. This is to avoid potential convergence issues in concurrent editing scenarios. Instead, the RHT Node is marked as isRemoved.
yorkie/pkg/document/crdt/rht.go
Lines 122 to 123 in 5ce2aa3
However, this approach of just marking the nodes as isRemoved can lead to memory issues if the number of marked RHT Nodes keeps increasing. Therefore, it is necessary to implement a garbage collector that handles tombstones to remove the marked nodes from memory.
Why is this needed:
To address potential memory issues caused by the increasing number of marked RHT Nodes and improve the efficiency of the RHT implementation.
The text was updated successfully, but these errors were encountered: