Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cropping options #164

Closed
3 tasks done
beast-14 opened this issue Dec 24, 2023 · 3 comments · Fixed by #170
Closed
3 tasks done

Some cropping options #164

beast-14 opened this issue Dec 24, 2023 · 3 comments · Fixed by #170
Labels
enhancement New feature or request

Comments

@beast-14
Copy link

Describe your suggested feature

I would like you to introduce crop, stretch, fit, centre options for wallpaper, I request you ..

Other details

Thankyou

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@beast-14 beast-14 added the enhancement New feature or request label Dec 24, 2023
@ghost
Copy link

ghost commented Dec 27, 2023

+1

@ghost
Copy link

ghost commented Dec 27, 2023

For a bit of context: Currently, when non-standard size or landscape local images are used for the lock screen (not multiple screens like on the home screens), it defaults to selecting the top left corner of the image.

If the image has been cropped or edited, sometimes it will stretch the image.

Now, most landscape photos have the important people/context in the centre, rather in the top left corner. Logic would dictate, that when cropping that image for the wallpaper, the default method (or at the very least, an option) should be center (not top left).

A more detailed explanations of what should be the default cropping methods imho are as follows:

First of all, the definitions to avoid confusion - the x axis of the screen is always the horizontal axis of the screen when the phone is held upright (portrait orientation). Y is the vertical axis.

Single screen (lock screen):

The y axis of the image should be matched to the y axis of the screen size and the image centered on the x axis. That is unless the x axis is smaller then the screen x axis, in which case do the opposite - first match x to the screen x and then centre the y.

If both x and y axis are smaller then the screen, use the closer match. If both matches are equal - default to using the y axis.

If both are bigger than the screen size, zoom out the image until the y axis matches that of the screen, unless the x axis becomes smaller than the screen x - you get the idea.

I think currently, none of this is happening.

Many thanks.

@ghost
Copy link

ghost commented Dec 27, 2023

For the home screen, when multiple screens/scroll are involved, a more complex version of the above should apply. For example, if the user has two screens, the x axis should be centered between them (not start top left). If 3, the image should be centered on the 2nd, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant