From f2014d85d45416301d5865c958e0005aaf137631 Mon Sep 17 00:00:00 2001 From: Junxiao Shi Date: Sat, 9 Mar 2024 07:26:01 +0000 Subject: [PATCH] ws-transport: delete close code WebSocket.close() does not accept code=1002 per MDN reference. --- integ/browser-tests/package.json | 4 ++-- mk/package.json | 2 +- pkg/autoconfig/package.json | 2 +- pkg/keychain-cli/package.json | 2 +- pkg/keychain/package.json | 2 +- pkg/l3face/package.json | 2 +- pkg/nac/package.json | 2 +- pkg/ndncert/package.json | 4 ++-- pkg/nfdmgmt/package.json | 2 +- pkg/node-transport/package.json | 2 +- pkg/packet/package.json | 2 +- pkg/pyrepo/package.json | 2 +- pkg/repo-api/package.json | 2 +- pkg/repo/package.json | 2 +- pkg/segmented-object/package.json | 2 +- pkg/svs/package.json | 2 +- pkg/tlv/package.json | 2 +- pkg/trust-schema/package.json | 2 +- pkg/util/package.json | 2 +- pkg/ws-transport/src/ws-transport.ts | 4 ++-- 20 files changed, 23 insertions(+), 23 deletions(-) diff --git a/integ/browser-tests/package.json b/integ/browser-tests/package.json index a32c2a1b..a7d1e316 100644 --- a/integ/browser-tests/package.json +++ b/integ/browser-tests/package.json @@ -27,10 +27,10 @@ "@types/webpack": "^5.28.5", "fork-ts-checker-webpack-plugin": "^9.0.2", "html-webpack-plugin": "^5.6.0", - "puppeteer": "^22.4.0", + "puppeteer": "^22.4.1", "ts-loader": "^9.5.1", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "webpack": "^5.90.3", "webpack-cli": "^5.1.4", "webpack-dev-server": "^5.0.2" diff --git a/mk/package.json b/mk/package.json index 9e6b94a2..afa906a0 100644 --- a/mk/package.json +++ b/mk/package.json @@ -8,7 +8,7 @@ "js-yaml": "^4.1.0", "readlink": "^3.0.0", "split2": "^4.2.0", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" }, "dependencies": { "compare-versions": "6.1.0" diff --git a/pkg/autoconfig/package.json b/pkg/autoconfig/package.json index 0561ace8..25dcf3e2 100644 --- a/pkg/autoconfig/package.json +++ b/pkg/autoconfig/package.json @@ -41,6 +41,6 @@ "@types/default-gateway": "^7.2.2", "@types/koa": "^2.15.0", "koa": "^2.15.0", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" } } \ No newline at end of file diff --git a/pkg/keychain-cli/package.json b/pkg/keychain-cli/package.json index 629cc167..dd24eb5e 100644 --- a/pkg/keychain-cli/package.json +++ b/pkg/keychain-cli/package.json @@ -35,7 +35,7 @@ "env-var": "^7.4.1", "fast-chunk-string": "^1.0.1", "get-stdin": "^9.0.0", - "nodemailer": "^6.9.11", + "nodemailer": "^6.9.12", "prompts": "^2.4.2", "stdout-stream": "^2.0.0", "tslib": "^2.6.2", diff --git a/pkg/keychain/package.json b/pkg/keychain/package.json index d43850b5..694407ae 100644 --- a/pkg/keychain/package.json +++ b/pkg/keychain/package.json @@ -35,7 +35,7 @@ "idb-keyval": "^6.2.1", "mnemonist": "^0.39.8", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "wait-your-turn": "^1.0.1" }, "devDependencies": { diff --git a/pkg/l3face/package.json b/pkg/l3face/package.json index bfca13c9..43b759ba 100644 --- a/pkg/l3face/package.json +++ b/pkg/l3face/package.json @@ -36,7 +36,7 @@ "retry": "^0.13.1", "streaming-iterables": "^8.0.1", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "typescript-event-target": "^1.1.0" } } \ No newline at end of file diff --git a/pkg/nac/package.json b/pkg/nac/package.json index f0a67e27..604cd524 100644 --- a/pkg/nac/package.json +++ b/pkg/nac/package.json @@ -37,7 +37,7 @@ "@yoursunny/asn1": "0.0.20200718", "mnemonist": "^0.39.8", "tslib": "^2.6.2", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" }, "devDependencies": { "@ndn/l3face": "workspace:^", diff --git a/pkg/ndncert/package.json b/pkg/ndncert/package.json index 0e786ab3..4401e027 100644 --- a/pkg/ndncert/package.json +++ b/pkg/ndncert/package.json @@ -38,10 +38,10 @@ "ajv": "^8.12.0", "b64-lite": "^1.4.0", "imap-emails": "^1.0.4", - "nodemailer": "^6.9.11", + "nodemailer": "^6.9.12", "p-timeout": "^6.1.2", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "typescript-event-target": "^1.1.0" }, "devDependencies": { diff --git a/pkg/nfdmgmt/package.json b/pkg/nfdmgmt/package.json index 30492aff..0d29488d 100644 --- a/pkg/nfdmgmt/package.json +++ b/pkg/nfdmgmt/package.json @@ -39,7 +39,7 @@ "devDependencies": { "@ndn/l3face": "workspace:*", "@ndn/node-transport": "workspace:*", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "typescript-event-target": "^1.1.0" } } \ No newline at end of file diff --git a/pkg/node-transport/package.json b/pkg/node-transport/package.json index 655d37b4..c4abcb6f 100644 --- a/pkg/node-transport/package.json +++ b/pkg/node-transport/package.json @@ -28,7 +28,7 @@ "event-iterator": "^2.0.0", "p-event": "^6.0.1", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "url-format-lax": "^2.0.0", "url-parse-lax": "^5.0.0" }, diff --git a/pkg/packet/package.json b/pkg/packet/package.json index 6d5e08c2..1a65974f 100644 --- a/pkg/packet/package.json +++ b/pkg/packet/package.json @@ -31,7 +31,7 @@ "buffer-compare": "^1.1.1", "mnemonist": "^0.39.8", "tslib": "^2.6.2", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" }, "devDependencies": { "@types/buffer-compare": "^0.0.33" diff --git a/pkg/pyrepo/package.json b/pkg/pyrepo/package.json index ff9c12ef..c651632f 100644 --- a/pkg/pyrepo/package.json +++ b/pkg/pyrepo/package.json @@ -37,7 +37,7 @@ "p-defer": "^4.0.0", "streaming-iterables": "^8.0.1", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "typescript-event-target": "^1.1.0" }, "devDependencies": { diff --git a/pkg/repo-api/package.json b/pkg/repo-api/package.json index 9901c587..08935d18 100644 --- a/pkg/repo-api/package.json +++ b/pkg/repo-api/package.json @@ -43,6 +43,6 @@ "devDependencies": { "@ndn/node-transport": "workspace:*", "stream-mock": "^2.0.5", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" } } \ No newline at end of file diff --git a/pkg/repo/package.json b/pkg/repo/package.json index 1994edcc..d5fa630b 100644 --- a/pkg/repo/package.json +++ b/pkg/repo/package.json @@ -37,7 +37,7 @@ "memory-level": "^1.0.0", "streaming-iterables": "^8.0.1", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "typescript-event-target": "^1.1.0", "wait-your-turn": "^1.0.1" }, diff --git a/pkg/segmented-object/package.json b/pkg/segmented-object/package.json index 39407126..08675900 100644 --- a/pkg/segmented-object/package.json +++ b/pkg/segmented-object/package.json @@ -45,6 +45,6 @@ "@ndn/l3face": "workspace:*", "@ndn/repo-api": "workspace:*", "stream-mock": "^2.0.5", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" } } \ No newline at end of file diff --git a/pkg/svs/package.json b/pkg/svs/package.json index e3cb91eb..ff6a97b9 100644 --- a/pkg/svs/package.json +++ b/pkg/svs/package.json @@ -37,7 +37,7 @@ "@ndn/util": "workspace:*", "streaming-iterables": "^8.0.1", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "typescript-event-target": "^1.1.0" }, "devDependencies": { diff --git a/pkg/tlv/package.json b/pkg/tlv/package.json index 6987c72e..2d6176f2 100644 --- a/pkg/tlv/package.json +++ b/pkg/tlv/package.json @@ -29,6 +29,6 @@ "@ndn/util": "workspace:*", "mnemonist": "^0.39.8", "tslib": "^2.6.2", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" } } \ No newline at end of file diff --git a/pkg/trust-schema/package.json b/pkg/trust-schema/package.json index b5b43968..205f72ea 100644 --- a/pkg/trust-schema/package.json +++ b/pkg/trust-schema/package.json @@ -34,7 +34,7 @@ "@ndn/util": "workspace:*", "mnemonist": "^0.39.8", "tslib": "^2.6.2", - "type-fest": "^4.11.1" + "type-fest": "^4.12.0" }, "devDependencies": { "@ndn/l3face": "workspace:^", diff --git a/pkg/util/package.json b/pkg/util/package.json index 27d8a695..8b9e636d 100644 --- a/pkg/util/package.json +++ b/pkg/util/package.json @@ -34,7 +34,7 @@ "minimalistic-assert": "^1.0.1", "streaming-iterables": "^8.0.1", "tslib": "^2.6.2", - "type-fest": "^4.11.1", + "type-fest": "^4.12.0", "wait-your-turn": "^1.0.1" }, "devDependencies": { diff --git a/pkg/ws-transport/src/ws-transport.ts b/pkg/ws-transport/src/ws-transport.ts index 03d771e9..98ae102f 100644 --- a/pkg/ws-transport/src/ws-transport.ts +++ b/pkg/ws-transport/src/ws-transport.ts @@ -21,7 +21,7 @@ export class WsTransport extends Transport { try { await pEvent(sock, "open", { timeout: opts.connectTimeout ?? 10000 }); } catch (err: unknown) { - sock.close(1002); + sock.close(); throw err; } } @@ -87,7 +87,7 @@ export class WsTransport extends Transport { } public close(): void { - this.sock.close(1000); + this.sock.close(); } /** Reopen the transport by connecting again with the same options. */