Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there's no isErevRoshChodesh(). implemetation #13

Open
emaayan opened this issue Jan 12, 2024 · 1 comment
Open

there's no isErevRoshChodesh(). implemetation #13

emaayan opened this issue Jan 12, 2024 · 1 comment

Comments

@emaayan
Copy link

emaayan commented Jan 12, 2024

i was looking for a the that comparable to isErevRoshChodesh in kosherZmanim, but i can't seem to find one, to me it looks like it would be like this:

bool isMacharRoshChodesh(const hdate hebrewDate)
{
    return hebrewDate.day == 29 && hebrewDate.month != 6;
}
@giggty
Copy link

giggty commented Sep 10, 2024

there is none ... i added myslef i think it's correct... ask yparitcher ...

  1. hdateformat.c file :
    add after :
case ROSH_CHODESH:
return "ראש חודש";

this :

case EREV_ROSH_CHODESH:
return "ערב ראש חודש";

2.hebrewcalander.c :
add : ( better after the getroshchodesh function... )

yomtov geterevroshchodesh(hdate date)
{
	if (date.day == 29 && date.month != 6)  // 6 for elul ...
	{return EREV_ROSH_CHODESH;}
	return CHOL;
}
  1. hebrewcalander.h :
    add to " // enum of yomtovs "after ROSH_CHODESH
    EREV_ROSH_CHODESH

and add: ( better after yomtov getroshchodesh(hdate date); ... )
yomtov geterevroshchodesh(hdate date);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants