Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar visibility #1627

Merged
merged 2 commits into from
Feb 15, 2014
Merged

Calendar visibility #1627

merged 2 commits into from
Feb 15, 2014

Conversation

jafl
Copy link
Contributor

@jafl jafl commented Feb 11, 2014

Fix calendar to use visibility:inherit instead of visibility:visible, for compatibility with overlays.

@juandopazo
Copy link
Member

Do you think this should be done with a CSS class?

@jafl
Copy link
Contributor Author

jafl commented Feb 11, 2014

It could, but since it's a single style, I'm not sure it's worth the extra code in the CSS file :)

@juandopazo
Copy link
Member

Deferring to @okuryu then.

@okuryu
Copy link
Member

okuryu commented Feb 12, 2014

I think it doesn't need to have any CSS class for this.

@jafl Could you provide an example that causes problems with visibility: visible?

@jafl
Copy link
Contributor Author

jafl commented Feb 12, 2014

Here is an example: http://jafl.github.io/yui-modules/datetime/

Click the date field under "Date & Time Popup". Then click elsewhere.

In the debugger, you can see that the overlay container has the class "yui3-inputpopup-hidden" which sets visibility:hidden, but the calendar is still visible, because "yui3-calendar-content" has visibility:visible explicitly set.

My patch modifies that to visibility:inherit, so "yui3-calendar-content" doesn't interfere with parent settings.

@okuryu
Copy link
Member

okuryu commented Feb 13, 2014

Thanks for the great example!

It looks that not only just the .yui3-calendar-content but the .yui3-calendar-grid has visibility:visible style. Do you think it doesn't need to change as the yui3-calendar-content?

@jafl
Copy link
Contributor Author

jafl commented Feb 13, 2014

My pull request covers both. I patched both _afterDateChange() and _rerenderCalendarPane().

@okuryu
Copy link
Member

okuryu commented Feb 14, 2014

Aha, thanks. I could confirm that it works. Looks good to me.

@okuryu okuryu merged commit 8506424 into yui:dev-master Feb 15, 2014
@okuryu
Copy link
Member

okuryu commented Feb 15, 2014

Merged into dev-master and dev-3.x. Thanks!

@okuryu okuryu added this to the Sprint 12 Code Freeze milestone Feb 15, 2014
@okuryu okuryu self-assigned this Feb 15, 2014
@okuryu okuryu removed the 3 - Review label Feb 15, 2014
@jafl jafl deleted the calendar-visibility branch January 29, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants