Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix horizonal position on contentEditable elements #92

Merged
merged 1 commit into from
Jul 1, 2014

Conversation

judev
Copy link
Contributor

@judev judev commented Jul 1, 2014

The dropdown currently appears too far to the right because getCaretRelativePosition isn't adjusting the left property to make it relative to its parent.

This bug is visible on your demo page: http://yuku-t.com/jquery-textcomplete/

This PR adjusts the left position to correct the issue.

@yuku
Copy link
Owner

yuku commented Jul 1, 2014

Hi @judev
Thanks for the patch. Looks good to me!

yuku added a commit that referenced this pull request Jul 1, 2014
fix horizonal position on contentEditable elements
@yuku yuku merged commit 12b2d8f into yuku:master Jul 1, 2014
@yuku yuku added the bug label Jul 1, 2014
@yuku yuku added the DEPRECATED jquery-textcomplete Issues associated to jquery-textcomplete (was DEPRECATED) label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DEPRECATED jquery-textcomplete Issues associated to jquery-textcomplete (was DEPRECATED)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants