-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "Seek to Precise Position" results in rewinding #58
Comments
Fixed in version (0.12.0). |
Unfortunately, it's not fixed for me, after using "seek to precise position" position is rewinded back. |
Can confirm its still present in latest version as well |
Same for me, "Rewinded due to time difference with user8606" rewinds to 0 on connection |
@FrozenAlex "Rewinded due to time difference", has something to do with a different issue under the hood, albeit indirectly linked to the issue at hand here. I believe all the modifications related to mpv integration broke a lot of stuff. For the meantime, I suggest temporarily using the previous version, |
@yuroyami Unrelated question, but how do I contribute to the project? I'd like to try fix this bug. I tried 2 versions of android studio and nothing works and your commit history seems pretty incomplete. |
@FrozenAlex I've encountered this issue with a +100ms as well so there could be something wrong with the protocol behavior itself. You're very welcome to take a shot at it since I am currently more focused on other stuff. But for the meantime, this repository became only a submodule of another larger repository (syncplay-mobile) that I haven't made public as of yet, said repo will host the full code for the Kotlin multiplatform project. That said, the code will undergo major changes since I am migrating into Clean architecture of sorts. Consequently, this repository will only host the Android-only code, which in and of itself will not compile. You can still grab the complete source code as of 0.12.0 from the release page itself, it should run fine with the latest Android Studio beta, take your time at finding the faulty part of the code. Otherwise, you can wait a week or two until the KMM source code is complete and syncplay-mobile to be made public, at which point you could grab the latest modified code. Either way, you could create a PR as soon as the next version is live, hopefully it won't take long. |
Should be fixed in v0.13.0 |
After seeking to precise location position is rewinding most of the times.
The text was updated successfully, but these errors were encountered: