Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "Seek to Precise Position" results in rewinding #58

Closed
soredake opened this issue Feb 28, 2023 · 8 comments
Closed

Using "Seek to Precise Position" results in rewinding #58

soredake opened this issue Feb 28, 2023 · 8 comments
Assignees

Comments

@soredake
Copy link

After seeking to precise location position is rewinding most of the times.

@yuroyami yuroyami self-assigned this Mar 1, 2023
@yuroyami
Copy link
Owner

yuroyami commented Jun 3, 2023

Fixed in version (0.12.0).

@yuroyami yuroyami closed this as completed Jun 3, 2023
@soredake
Copy link
Author

soredake commented Jun 3, 2023

Unfortunately, it's not fixed for me, after using "seek to precise position" position is rewinded back.

@yuroyami yuroyami reopened this Jun 3, 2023
@xpt1x
Copy link

xpt1x commented Aug 18, 2023

Can confirm its still present in latest version as well
Seek to position, works on my device, but for other users connected rewinds back to 0

@FrozenAlex
Copy link

FrozenAlex commented Sep 1, 2023

Same for me, "Rewinded due to time difference with user8606" rewinds to 0 on connection
Seems kinda unusable when rewinding a lot. Every time I rewind there is a chance of it going back all the time and the desync sometimes is huge

@yuroyami
Copy link
Owner

yuroyami commented Sep 1, 2023

@FrozenAlex "Rewinded due to time difference", has something to do with a different issue under the hood, albeit indirectly linked to the issue at hand here. I believe all the modifications related to mpv integration broke a lot of stuff. For the meantime, I suggest temporarily using the previous version, 0.11.1

@FrozenAlex
Copy link

FrozenAlex commented Sep 2, 2023

@yuroyami 0.11.1 is also quite bad with rewinds tbh. Every time I run it with desktop version (v1.7.0) it rewinds all the time back when skipping. Also the 0.11.1 does not load the file if it's being played in the room and you open it. I have about 110ms of ping but it should not matter much. I think the bug is happening cause the progress is being sent too often? And when rewind event comes it sends back the old position and the progress resets?

Unrelated question, but how do I contribute to the project? I'd like to try fix this bug. I tried 2 versions of android studio and nothing works and your commit history seems pretty incomplete.

@yuroyami
Copy link
Owner

yuroyami commented Sep 2, 2023

@FrozenAlex I've encountered this issue with a +100ms as well so there could be something wrong with the protocol behavior itself. You're very welcome to take a shot at it since I am currently more focused on other stuff. But for the meantime, this repository became only a submodule of another larger repository (syncplay-mobile) that I haven't made public as of yet, said repo will host the full code for the Kotlin multiplatform project. That said, the code will undergo major changes since I am migrating into Clean architecture of sorts. Consequently, this repository will only host the Android-only code, which in and of itself will not compile.

You can still grab the complete source code as of 0.12.0 from the release page itself, it should run fine with the latest Android Studio beta, take your time at finding the faulty part of the code. Otherwise, you can wait a week or two until the KMM source code is complete and syncplay-mobile to be made public, at which point you could grab the latest modified code. Either way, you could create a PR as soon as the next version is live, hopefully it won't take long.

@yuroyami
Copy link
Owner

yuroyami commented Jan 6, 2024

Should be fixed in v0.13.0

@yuroyami yuroyami closed this as completed Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants