New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic numbers used in code of MST Circuit to create PoseidonChip #15

Open

bbresearcher opened this issue Mar 6, 2024 · 0 comments

Collaborator

bbresearcher commented Mar 6, 2024

Describe the bug
There are hardcoded integers used in the construction of the Poseidon chips

Expected behavior
Either create named constants or document the values used in a comment

Additional context
https://github.com/summa-dev/summa-solvency/blob/master/zk_prover/src/circuits/merkle_sum_tree.rs#L237-L245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment