Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV parsing allows duplicate crypto tokens. #5

Open
bbresearcher opened this issue Apr 16, 2024 · 0 comments
Open

CSV parsing allows duplicate crypto tokens. #5

bbresearcher opened this issue Apr 16, 2024 · 0 comments

Comments

@bbresearcher
Copy link

bbresearcher commented Apr 16, 2024

Describe the bug
The CSV parsing function and code allows for the CSD import to contain duplicate crypto tokens.
This was discussed and does not seem to have any security impact however it was decided to restrict columns to be unique.

To Reproduce
using any csv data as below still works.

username,balance_ETH_ETH,balance_ETH_ETH
dxGaEAii,11888,41163
MBlfbBGI,67823,18651

running the command cargo run --release --example summa_solvency_flow still generates successfully.

1. Ownership proofs are submitted successfully!
2. Commitment is submitted successfully!
3. Exported proof to user #1, as `user_1_proof.json`
4. Verifying the proof on contract veirifer for User #1: true

Expected behavior
Crypto token columns should be unique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant