Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect permutation length in validateVKPermuationsLength #6

Open
zeroqn opened this issue Apr 17, 2024 · 0 comments
Open

Incorrect permutation length in validateVKPermuationsLength #6

zeroqn opened this issue Apr 17, 2024 · 0 comments

Comments

@zeroqn
Copy link

zeroqn commented Apr 17, 2024

Describe the bug

The error arises from the range check lookup table. For instance, when the balanceByteRange is set to 9, we expect to have four 2^16 lookup tables plus an additional 2^8 or 2^16 lookup table. balanceByteRange / 2 return 4, which is wrong.

To Reproduce

change balanceByteRange to 9
https://github.com/summa-dev/summa-solvency/blob/v2/contracts/test/Summa.ts#L43

Expected behavior

test should fail

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant