Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentence trigger function signature has changed in HA 2024.4 #260

Closed
synesthesiam opened this issue Apr 4, 2024 · 0 comments · Fixed by #259
Closed

Sentence trigger function signature has changed in HA 2024.4 #260

synesthesiam opened this issue Apr 4, 2024 · 0 comments · Fixed by #259

Comments

@synesthesiam
Copy link

As of 2024.4, the callback function signature for sentence triggers has an additional parameter (device_id).

This code here needs to change:

hass-node-red/custom_components/nodered/websocket.py

Line 311 in 16b40cd

async def handle_trigger(sentence: str, result: RecognizeResult = None) -> str:

It needs to become:

async def handle_trigger(sentence: str, result: RecognizeResult = None, device_id : str | None) -> str:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 3.1.4 zachowj/hass-node-red
1 participant
@synesthesiam