From dd34f0911d655ea81926b8b014f34872937f367a Mon Sep 17 00:00:00 2001 From: Foivos Zakkak Date: Mon, 15 May 2023 11:45:18 +0300 Subject: [PATCH 1/2] Do not attempt to detect container runtime in native-sources build Closes: #33161 --- .../steps/NativeImageBuildRunnerDummy.java | 34 +++++++++++++++++++ .../pkg/steps/NativeImageBuildStep.java | 12 ++++++- .../main/asciidoc/building-native-image.adoc | 5 +-- 3 files changed, 48 insertions(+), 3 deletions(-) create mode 100644 core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunnerDummy.java diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunnerDummy.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunnerDummy.java new file mode 100644 index 0000000000000..63ac4411aea39 --- /dev/null +++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunnerDummy.java @@ -0,0 +1,34 @@ +package io.quarkus.deployment.pkg.steps; + +import java.nio.file.Path; +import java.util.List; + +public class NativeImageBuildRunnerDummy extends NativeImageBuildRunner { + + private static final String MESSAGE = "NativeImageBuildRunnerDummy is note meant to be used to perform an actual build."; + private final boolean isContainer; + + public NativeImageBuildRunnerDummy(boolean isContainer) { + this.isContainer = isContainer; + } + + @Override + public boolean isContainer() { + return isContainer; + } + + @Override + protected String[] getGraalVMVersionCommand(List args) { + throw new RuntimeException(MESSAGE); + } + + @Override + protected String[] getBuildCommand(Path outputDir, List args) { + throw new RuntimeException(MESSAGE); + } + + @Override + protected void objcopy(Path outputDir, String... args) { + throw new RuntimeException(MESSAGE); + } +} diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java index e4c313fcb650f..3885c3bb73598 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java @@ -329,7 +329,7 @@ private String getResultingExecutableName(String nativeImageName, boolean isCont /** * Resolves the runner factory. Happens quite early, *before* the build. */ - @BuildStep + @BuildStep(onlyIf = NativeBuild.class) public NativeImageRunnerBuildItem resolveNativeImageBuildRunner(NativeConfig nativeConfig) { boolean isExplicitContainerBuild = nativeConfig.containerBuild() .orElse(nativeConfig.containerRuntime().isPresent() || nativeConfig.remoteContainerBuild()); @@ -353,6 +353,16 @@ public NativeImageRunnerBuildItem resolveNativeImageBuildRunner(NativeConfig nat return new NativeImageRunnerBuildItem(new NativeImageBuildLocalContainerRunner(nativeConfig)); } + /** + * Creates a dummy runner for native-sources builds. This allows the creation of native-source jars without + * requiring podman/docker or a local native-image installation. + */ + @BuildStep(onlyIf = NativeSourcesBuild.class) + public NativeImageRunnerBuildItem dummyNativeImageBuildRunner(NativeConfig nativeConfig) { + boolean explicitContainerBuild = nativeConfig.isExplicitContainerBuild(); + return new NativeImageRunnerBuildItem(new NativeImageBuildRunnerDummy(explicitContainerBuild)); + } + private void copyJarSourcesToLib(OutputTargetBuildItem outputTargetBuildItem, CurateOutcomeBuildItem curateOutcomeBuildItem) { Path targetDirectory = outputTargetBuildItem.getOutputDirectory() diff --git a/docs/src/main/asciidoc/building-native-image.adoc b/docs/src/main/asciidoc/building-native-image.adoc index 8620002a85b7a..3e0243d52d816 100644 --- a/docs/src/main/asciidoc/building-native-image.adoc +++ b/docs/src/main/asciidoc/building-native-image.adoc @@ -786,10 +786,11 @@ $ ./mvnw clean package -Dquarkus.package.type=native-sources -Dquarkus.native.co cd target/native-sources docker run \ -it \ + --user $(id -ur):$(id -gr) \ --rm \ - --v $(pwd):/work \# <1> + -v $(pwd):/work \# <1> -w /work \# <2> - --entrypoint bin/sh \ + --entrypoint /bin/sh \ $(cat native-builder.image) \# <3> -c "native-image $(cat native-image.args) -J-Xmx4g"# <4> ---- From e44ed7b565141d441492f20a51cd4da5c2644771 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 15 May 2023 08:56:45 +0000 Subject: [PATCH 2/2] Bump quarkus-spring-api.version from 5.2.SP7 to 5.2.Final Bumps `quarkus-spring-api.version` from 5.2.SP7 to 5.2.Final. Updates `quarkus-spring-core-api` from 5.2.SP7 to 5.2.Final - [Commits](https://github.com/quarkusio/quarkus-spring-api/commits/5.2.Final) Updates `quarkus-spring-context-api` from 5.2.SP7 to 5.2.Final - [Commits](https://github.com/quarkusio/quarkus-spring-api/commits/5.2.Final) Updates `quarkus-spring-beans-api` from 5.2.SP7 to 5.2.Final - [Commits](https://github.com/quarkusio/quarkus-spring-api/commits/5.2.Final) Updates `quarkus-spring-web-api` from 5.2.SP7 to 5.2.Final - [Commits](https://github.com/quarkusio/quarkus-spring-api/commits/5.2.Final) Updates `quarkus-spring-webmvc-api` from 5.2.SP7 to 5.2.Final - [Commits](https://github.com/quarkusio/quarkus-spring-api/commits/5.2.Final) --- updated-dependencies: - dependency-name: io.quarkus:quarkus-spring-core-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-spring-context-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-spring-beans-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-spring-web-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-spring-webmvc-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- bom/application/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bom/application/pom.xml b/bom/application/pom.xml index 78d358cf178cc..08fbd553d51e5 100644 --- a/bom/application/pom.xml +++ b/bom/application/pom.xml @@ -177,7 +177,7 @@ 1.17.2 0.2.1 4.6.3 - 5.2.SP7 + 5.2.Final 2.1.SP2 5.4.Final 2.1.SP1