Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user notifications #92

Closed
zanematthew opened this issue Jan 23, 2015 · 0 comments
Closed

New user notifications #92

zanematthew opened this issue Jan 23, 2015 · 0 comments
Labels
Milestone

Comments

@zanematthew
Copy link
Owner

New user notifications are not being sent. It appears that the function wp_new_user_notification should be fired after the user has successfully registered.

What needs to be done is:

The wp_new_user_notification needs to be fired after a new user has been successfully added.

There's currently two locations this would need to be added; one is in the create_facebook_user method, and the other is in the register_submit method.

Ideally rather than just adding the new user notice method in two locations, the said methods would be re-factored to only be required to set-up the needed params, and hand them off to one single register method, i.e., we would move wp_create_user, and wp_insert_user(honestly not sure why I used two different wp functions?) from those methods into one method that is called by both, $this->register( $user ).

Also:

This would change names to setup_user(), since it would only handle setting the params for the user.
public function register_submit()

This would change names to setup_facebook_user(), since it would only handle setting params for the fb user
public function create_facebook_user()

Both of these would then call the following, which handles adding the new user, and return a status code of sorts.
public function register( $params )

Additionally the settings for WP, and WP Networking allowing new user notifications to be sent need to be taken into consideration, along with the custom email that the Pro version sends.

@zanematthew zanematthew modified the milestone: 1.0.9 Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant