-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for auto-relax after poetry add
#5
Comments
poetry's default of capping upperbounds, is a timebomb waiting to explode. |
the arguments are well known, but ignored for now: |
To clarify: I meant I would monkeypatch this in my local setups. |
Why after, and not during? Why the whole machinery of "plugins" and then make zero use of it? |
To provide some clarity here: Yes, you could use |
If people are interested in trying this, I have a draft implementation at #49 I need to add test coverage, so expect there to be problems still. |
@zanieb Yes, I think this would be a great addition. If worried about the loose definition of "changing", |
It's unclear if Poetry would disapprove of this as their documentation states that core command behavior should not be changed but a maintainer notes that a plugin may be a good way to change the default behavior in this comment.
It seems as though it would be straight-forward to add a hook after the
add
command runs that modifies thepyproject.toml
using the mechanisms established for thepoetry relax
command. It's a little redundant to parse the file again, but I doubt the impact on speed will be noticeable.If added, this would include a configurable toggle and would likely be off my default.
This issue will track requests for this feature. Feel free to add a 👍 or 👎 reaction here. Additional thoughts are welcome.
The text was updated successfully, but these errors were encountered: