Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add pre-commit hook #61

Open
adam-grant-hendry opened this issue Aug 25, 2023 · 4 comments
Open

[FEAT]: Add pre-commit hook #61

adam-grant-hendry opened this issue Aug 25, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@adam-grant-hendry
Copy link

Could we please add a pre-commit hook for this project?

`.pre-commit-hooks.yaml

- id: poetry-relax
  name: poetry-relax
  description: A poetry plugin to relax dependency versions when publishing libraries.
  entry: poetry relax
  language: python
  language_version: python3
  pass_filenames: false
  files: ^pyproject.toml$
@zanieb
Copy link
Owner

zanieb commented Aug 25, 2023

Sounds good to me, but for https://github.com/astral-sh/ruff-pre-commit/ we had to put it in a separate repository and I don't remember why. I'm not sure if I want to maintain it if so because then I have to manage version bumps across repositories and there just aren't enough users of this project to merit it at this point.

@zanieb zanieb added the enhancement New feature or request label Aug 25, 2023
@adam-grant-hendry
Copy link
Author

@zanieb May I maintain it?

@zanieb
Copy link
Owner

zanieb commented Aug 25, 2023

@adam-grant-hendry yeah you're welcome to do so! If you want to create a repository we can link to it from the README here otherwise I could create the repository and add you as a maintainer.

@adam-grant-hendry
Copy link
Author

I'm happy to make the repo and yes, let's link it in the README. I'll take a stab at it and report back 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants