Remove factor of 6 #161
Merged
Remove factor of 6 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Code Coverage |
pediejo
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Looks good! My only suggestion is that in your PR comments that instead of linking to the Jira ticket (which people outside of Zapata can't see) that you paste the content from the Jira ticket into your PR description. This would help someone follow why this change was made.
| @@ -467,7 +467,7 @@ def estimate_resources_from_compiled_implementation( | |||
|
|
|||
| # get time to get a single shot | |||
| time_per_circuit_in_seconds = ( | |||
| 6 * num_cycles * hw_model.surface_code_cycle_time_in_seconds | |||
| num_cycles * hw_model.surface_code_cycle_time_in_seconds | |||
There was a problem hiding this comment.
Just a comment: I was surprised to see that the unit tests are still passing after making this change. But, I now see that it is because our tests don't depend on the absolute value of time_per_circuit_in_seconds, but only on how this value is expected to change with respect to other parameters (e.g. physical error rate). I think this is good because it shows that these tests are checking something that we expect to be the case rather than checking output values against values generated from the tests themselves, which are weaker and subject to breaking even when the code is updated properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
The issue involves removing the factor of 6 from BenchQ to correct inconsistencies in the runtime calculation.
Context:
This factor of six is because the syndrome extraction circuits have depth 6 when assuming direct physical ability to initialise and readout qubits in the X-basis. There is a discrepancy in the terminology used, which stems from the historical use of gate_time instead of surface_code_cycle_time. The factor of six needs to be removed to align the equations with the updated terminology.
Implemented solution:
Removed factor of 6 from time_per_circuit_in_seconds in graph_estimator.py in line 469