Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: multiple scans overwrite the zap_scan artifact #38

Closed
WalterMoar opened this issue Apr 29, 2022 · 2 comments
Closed

Issue: multiple scans overwrite the zap_scan artifact #38

WalterMoar opened this issue Apr 29, 2022 · 2 comments

Comments

@WalterMoar
Copy link

I'm loving the GitHub Action for running ZAP scans, thank you! 💯

One issue is that when running two scans in parallel they're both creating an artifact called zap_scan. So there is a race condition and whichever scan completes first has its artifact overwritten by the scan that finished second. To get around this, after the scan completes I am uploading report_html.html as two differently-named artifacts. However, this still leaves the zap_scan artifact and it is a bit confusing that we have an extra artifact that is essentially a duplicate of one of the other artifacts - although we never know which one. Since artifacts aren't available until after the Action has completed, they cannot be deleted in the Action that created them.

A couple of possibilities are:

  1. Have a setting for the name of the artifact (ideal)
  2. Have a flag that can turn off the uploading of the zap_scan artifact and users will upload with their own name.

Thank you!

@thc202
Copy link
Member

thc202 commented Apr 29, 2022

The first bullet is planned (e.g. zaproxy/action-baseline#45).

@WalterMoar
Copy link
Author

Oh, perfect! I didn't realize there was another repo that I should have been looking in. Thank you, looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants