Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache incoming viewing keys and detect IVK collisions when adding accounts #1490

Open
daira opened this issue Aug 10, 2024 · 0 comments
Open
Labels
A-wallet Area: light wallet backend.

Comments

@daira
Copy link
Contributor

daira commented Aug 10, 2024

In #1489 we added a check for collisions between FVK components when adding accounts.

As part of supporting Incoming accounts, we should:

  • Use a migration to add orchard_ivk_item_cache, sapling_ivk_item_cache, and p2pkh_ivk_item_cache to the addresses table in addition to the existing orchard_fvk_item_cache, sapling_fvk_item_cache, and p2pkh_fvk_item_cache, and make all of these UNIQUE.
  • Change the FVK collision check to an IVK collision check. (If two accounts collide on FVK then they necessarily also collide on IVK, and there is negligible chance that two different FVKs produce colliding IVKs.)

These don't need to block on other changes for IVK support.

@daira daira added the A-wallet Area: light wallet backend. label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-wallet Area: light wallet backend.
Projects
None yet
Development

No branches or pull requests

1 participant