Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't pass Set class into import #680

Open
camallen opened this issue May 26, 2020 · 1 comment
Open

Can't pass Set class into import #680

camallen opened this issue May 26, 2020 · 1 comment

Comments

@camallen
Copy link

I'm using a set to create a uniq list of AR records to upsert into my database.

It appears that there is a direct test for Array in

if args.last.is_a?( Array ) && args.last.first.is_a?(ActiveRecord::Base)

Would you be open to a PR to allow duck type objects that behave like arrays?

@jkowens
Copy link
Collaborator

jkowens commented May 27, 2020

Hi @camallen, I haven't been spending much time with this code base lately so I can't think of any potential roadblocks off the top of my head. I would be open to a PR if you find that it is feasable.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants