Add zoom shortcuts ctrl + (+-0) #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zealdocs#767: if needed ctrl+= is easy to add It really helps when using a touchpad ;)
trollixx
requested changes
Oct 17, 2018
src/libs/ui/mainwindow.cpp
Outdated
| @@ -218,6 +218,15 @@ MainWindow::MainWindow(Core::Application *app, QWidget *parent) : | |||
| connect(ui->actionForward, &QAction::triggered, this, [this]() { currentTab()->forward(); }); | |||
| addAction(ui->actionForward); | |||
|
|
|||
| shortcut = new QShortcut(QStringLiteral("Ctrl++"), this); | |||
There was a problem hiding this comment.
This should be:
Suggested change
| shortcut = new QShortcut(QStringLiteral("Ctrl++"), this); | |
| shortcut = new QShortcut(QKeySequence::ZoomIn, this); |
src/libs/ui/mainwindow.cpp
Outdated
| connect(shortcut, &QShortcut::activated, this, [this]() { currentTab()->zoomIn(); }); | ||
| shortcut = new QShortcut(QStringLiteral("Ctrl+="), this); | ||
| connect(shortcut, &QShortcut::activated, this, [this]() { currentTab()->zoomIn(); }); | ||
| shortcut = new QShortcut(QStringLiteral("Ctrl+-"), this); |
There was a problem hiding this comment.
Suggested change
| shortcut = new QShortcut(QStringLiteral("Ctrl+-"), this); | |
| shortcut = new QShortcut(QKeySequence::ZoomOut, this); |
|
Thanks for the feedback, let me know if there's any other change needed. |
trollixx
approved these changes
Oct 18, 2018
trollixx
approved these changes
Oct 19, 2018
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #767: if needed ctrl+= is easy to add
It really helps when using a touchpad ;)