In-page JavaScript links are treated as external links

[toupeira]

I recently upgraded Zeal from 0.4 to 0.6 (using the Debian package) and noticed in the Rails docset that the "show" links to toggle the source for a method stopped working and now trigger the new dialog for opening external links:

The href of these look like javascript:toggleSource('method-i-change_column_source'). Other docsets using onclick might have the same issue.

It looks like this bug was introduced with the changes in https://github.com/peterhoeg/zeal/commit/c2ca28fbde0cd42f97204e712c519917cd05419b.

I also tried changing the link behaviour to "Open in Zeal", but then nothing happens if I click JS links.

[toupeira]

@trollixx thanks for the fix :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for a related request.