Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synchronization support #23

Closed
3 of 10 tasks
bbannier opened this issue Apr 6, 2020 · 2 comments
Closed
3 of 10 tasks

Add synchronization support #23

bbannier opened this issue Apr 6, 2020 · 2 comments
Assignees
@bbannier
Labels
Port V1 Functionality that still needs to ported from the the old Spicy research prototype

Comments

@bbannier
Copy link
Member

bbannier commented Apr 6, 2020 •
edited by rsmmr
Loading

(Setting to low priority, we'll do this once the main parsing stuff is in place)

  • Spicy:

    • Unit parsing

      • Add "resynchronization mode"

    • Marks

      • Add type for mark
      • Add runtime API to insert marks into input
      • Extend Spicy driver to allow specifying marks

    • Unit properties

      • %sync-after/%sync-at at bytes
      • %sync-after/%sync-at at regex
      • %sync-after/%sync-at at mark
      • %sync-after/%sync-at at object

    • Parse attributes

      • &synchronize

    • Unit hooks

      • %synced

Note that this needs to integrate with "trial mode" (see #24): If there are synchronization hints, entering trial mode enables resynchronization mode as well; see 2.7 in the Spicy paper.

The Spicy paper may generally be helpful to understand the synchronization strategy.

Old tests in https://github.com/rsmmr/hilti/tree/master/tests/spicy/synchronize.
@bbannier bbannier added Port V1 Functionality that still needs to ported from the the old Spicy research prototype Priority Low Spicy labels Apr 6, 2020
@bbannier
Copy link
Member Author

bbannier commented Apr 6, 2020

marked this issue as related to #118

@rsmmr rsmmr removed Spicy labels Apr 24, 2020
@rsmmr rsmmr mentioned this issue Jun 24, 2020
Closed
@rsmmr rsmmr mentioned this issue Aug 12, 2021
Closed
@bbannier bbannier self-assigned this Feb 2, 2022
@bbannier
Copy link
Member Author

Closing this as #1054 has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbannier bbannier

Labels
Port V1 Functionality that still needs to ported from the the old Spicy research prototype
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbannier @rsmmr