-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest watchpack with dynamic route rename fix #10351
Conversation
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 10.5s | 11s | |
nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.11 kB | 4.11 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | ✓ |
link.html gzip | 1.03 kB | 1.03 kB | ✓ |
withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 11s | 11s | |
nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.11 kB | 4.11 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_error.js gzip | 46.6 kB | 46.6 kB | ✓ |
404.html gzip | 1.42 kB | 1.42 kB | ✓ |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 46.8 kB | 46.8 kB | ✓ |
link.js gzip | 72.4 kB | 72.4 kB | ✓ |
routerDirect.js gzip | 70.4 kB | 70.4 kB | ✓ |
withRouter.js gzip | 70.5 kB | 70.5 kB | ✓ |
Overall change | 309 kB | 309 kB | ✓ |
Commit: f94964c
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 13.1s | 13.1s | |
nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.11 kB | 4.11 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | ✓ |
link.html gzip | 1.03 kB | 1.03 kB | ✓ |
withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 13.7s | 13.9s | |
nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.11 kB | 4.11 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_error.js gzip | 46.6 kB | 46.6 kB | ✓ |
404.html gzip | 1.42 kB | 1.42 kB | ✓ |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 46.8 kB | 46.8 kB | ✓ |
link.js gzip | 72.4 kB | 72.4 kB | ✓ |
routerDirect.js gzip | 70.4 kB | 70.4 kB | ✓ |
withRouter.js gzip | 70.5 kB | 70.5 kB | ✓ |
Overall change | 309 kB | 309 kB | ✓ |
Commit: 4fc80f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will defer to @Timer reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try to upgrade watchpack first to see if the bug is resolved? It may be better to fix this upstream for 2 reasons:
- Prevents re-crawling the file system (potentially slow, especially on windows with a large number of pages).
- This likely affects other webpack internals, so fixing it upstream would net a better result overall.
It looks like the error is still present upgrading to the latest version of Another alternative is we could check if the file exists on the filesystem still only for dynamic routes before adding them to our list. This prevents us from having to read the entire pages directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's contribute the fix to watchpack instead of enumerating the whole file system here (which may take a long time).
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 11.9s | 12.5s | |
nodeModulesSize | 52.7 MB | 52.7 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.14 kB | 5.14 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..4e43.js gzip | 16.2 kB | 16.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 70 kB | 70 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.14 kB | 4.14 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.7 kB | 64.7 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
index.html gzip | 1.03 kB | 1.03 kB | ✓ |
link.html gzip | 1.04 kB | 1.04 kB | ✓ |
withRouter.html gzip | 1.03 kB | 1.03 kB | ✓ |
Overall change | 3.11 kB | 3.11 kB | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 14.3s | 14.1s | -287ms |
nodeModulesSize | 52.7 MB | 52.7 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.14 kB | 5.14 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..4e43.js gzip | 16.2 kB | 16.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 70 kB | 70 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.14 kB | 4.14 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.7 kB | 64.7 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_error.js gzip | 289 kB | 290 kB | |
404.html gzip | 1.45 kB | 1.45 kB | ✓ |
hooks.html gzip | 1.08 kB | 1.08 kB | ✓ |
index.js gzip | 290 kB | 289 kB | -530 B |
link.js gzip | 319 kB | 319 kB | |
routerDirect.js gzip | 316 kB | 316 kB | |
withRouter.js gzip | 316 kB | 316 kB | |
Overall change | 1.53 MB | 1.53 MB |
Commit: 968481a
Opened PR for |
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 9.2s | 9.9s | |
nodeModulesSize | 53.8 MB | 53.8 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.05 kB | 5.05 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..abdd.js gzip | 12.2 kB | 12.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.13 kB | 4.13 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 9.2 kB | 9.2 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 20.3 kB | 20.3 kB | ✓ |
Overall change | 20.3 kB | 20.3 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.06 kB | 1.06 kB | ✓ |
_error.js gzip | 2.98 kB | 2.98 kB | ✓ |
hooks.js gzip | 664 B | 664 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 1.9 kB | 1.9 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 7.38 kB | 7.38 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 577 B | 577 B | ✓ |
_error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
hooks.module.js gzip | 370 B | 370 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
Overall change | 5.26 kB | 5.26 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
index.html gzip | 926 B | 926 B | ✓ |
link.html gzip | 933 B | 933 B | ✓ |
withRouter.html gzip | 923 B | 923 B | ✓ |
Overall change | 2.78 kB | 2.78 kB | ✓ |
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
buildDuration | 10.1s | 10.6s | |
nodeModulesSize | 53.8 MB | 53.8 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.js gzip | 5.05 kB | 5.05 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..abdd.js gzip | 12.2 kB | 12.2 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.13 kB | 4.13 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 9.2 kB | 9.2 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 20.3 kB | 20.3 kB | ✓ |
Overall change | 20.3 kB | 20.3 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.js gzip | 1.06 kB | 1.06 kB | ✓ |
_error.js gzip | 2.98 kB | 2.98 kB | ✓ |
hooks.js gzip | 664 B | 664 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 1.9 kB | 1.9 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 7.38 kB | 7.38 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_app.module.js gzip | 577 B | 577 B | ✓ |
_error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
hooks.module.js gzip | 370 B | 370 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
Overall change | 5.26 kB | 5.26 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | ijjk/next.js fix/dynamic-route-rename | Change | |
---|---|---|---|
_error.js gzip | 289 kB | 290 kB | |
404.html gzip | 1.33 kB | 1.33 kB | ✓ |
hooks.html gzip | 965 B | 965 B | ✓ |
index.js gzip | 289 kB | 289 kB | -342 B |
link.js gzip | 299 kB | 297 kB | -1.49 kB |
routerDirect.js gzip | 298 kB | 297 kB | -642 B |
withRouter.js gzip | 296 kB | 298 kB | |
Overall change | 1.47 MB | 1.47 MB | -831 B |
Commit: 9204090
The above PR with the fix in |
As noticed by @lfades when you rename a dynamic route changing only the filename's casing e.g.
[pid].js
->[PiD].js
and we attempt to re-generate the dynamic routeswebpack
reports both casings of the filenames causing us to duplicate the route which fails our dynamic route validation.This checks to make sure we don't add invalid pages from webpack to our dynamic routes by reading the pages directory separately when a change is detected and using that as the source of truth instead of webpack's report.
I also added a test case to help prevent regressing on this
Note: this doesn't just de-dupe ignoring casing since it's very possible there are files with the same name but differing casing which is an actual error