Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade loader-utils #11324

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Upgrade loader-utils #11324

merged 1 commit into from
Mar 24, 2020

Conversation

timneutkens
Copy link
Member

Fixes #11323

@timneutkens timneutkens mentioned this pull request Mar 24, 2020
Closed
@ijjk
Copy link
Member

ijjk commented Mar 24, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
buildDuration 10.6s 10.4s -208ms
nodeModulesSize 52.9 MB 53 MB ⚠️ +109 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 912 B 912 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
buildDuration 11.3s 11.3s -8ms
nodeModulesSize 52.9 MB 53 MB ⚠️ +109 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary timneutkens/next.js add/upgrade-deps-to-remove-unused-dependency Change
_error.js gzip 293 kB 294 kB ⚠️ +240 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 293 kB 294 kB ⚠️ +901 B
link.js gzip 301 kB 301 kB -444 B
routerDirect.js gzip 300 kB 299 kB -296 B
withRouter.js gzip 300 kB 300 kB ⚠️ +112 B
Overall change 1.49 MB 1.49 MB ⚠️ +513 B

Timer
Timer approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should be unaffected by listed breaking changes.

@Timer Timer added ready to land Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.). labels Mar 24, 2020
@Timer Timer added this to the 9.3.2 milestone Mar 24, 2020
@Timer Timer merged commit 876ae3f into vercel:canary Mar 24, 2020
@timneutkens timneutkens deleted the add/upgrade-deps-to-remove-unused-dependency branch March 24, 2020 14:00
@timneutkens
Copy link
Member Author

LGTM, we should be unaffected by listed breaking changes.

Yep exactly!

This was referenced Mar 27, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 13, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Merged
This was referenced Apr 22, 2020
Closed
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.).
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.

Vulnerability in loader-utils version
3 participants
@timneutkens @ijjk @Timer