Dedupe meta tags #8960

melanieseltzer · 2019-10-04T07:00:53Z

Hopefully I'm on the right track here... it seems like we can check for the prepended .$ in the keys set. If that exists and matches the current item in the filter, then a custom version of the tag was implemented, so ignore the default.

Fixes #8955

timneutkens · 2019-10-04T12:01:22Z

Hey Melanie! Could you add a test for this so that we can ensure it doesn't break in the future?

melanieseltzer · 2019-10-04T16:11:06Z

@timneutkens Sure thing! Would you mind telling me where I should add it? Is there a test file already existing or should I create a new one? Poked around a bit but not entirely sure where it should go...

Also, trying to run tests with yarn testonly but getting this over and over and the tests never actually start... am I doing something wrong?

ijjk · 2019-10-04T16:12:25Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	15.3s	15.4s	⚠️ +88ms
nodeModulesSize	48.3 MB	48.3 MB	-2.3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	945 B	945 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	942 B	942 B	✓
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for _error.js

@@ -303,7 +303,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Diff for _error.module.js

@@ -436,7 +436,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	15.5s	15.5s	⚠️ +74ms
nodeModulesSize	48.3 MB	48.3 MB	-2.3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_error.js	253 kB	254 kB	⚠️ +236 B
_error.js gzip	67.9 kB	68 kB	⚠️ +106 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	979 B	✓
index.js	254 kB	254 kB	⚠️ +236 B
index.js gzip	68.2 kB	68.3 kB	⚠️ +104 B
link.js	261 kB	262 kB	⚠️ +236 B
link.js gzip	70.3 kB	70.4 kB	⚠️ +101 B
routerDirect.js	255 kB	255 kB	⚠️ +236 B
routerDirect.js gzip	68.3 kB	68.4 kB	⚠️ +105 B
withRouter.js	254 kB	255 kB	⚠️ +236 B
withRouter.js gzip	68.4 kB	68.5 kB	⚠️ +105 B
Overall change	1.28 MB	1.28 MB	⚠️ +1.18 kB

Commit: 7c1d7ce

ijjk · 2019-10-05T11:06:01Z

Hi @melanieseltzer you might need to bump the chromedriver version to match your installed Google Chrome version, you should be able to do this with yarn add -W --dev chromedriver@latest (we're using an older version for our CI and are investigating better handling for this).

Then you'll probably want to run yarn testonly --runInBand --forceExit <TEST_FOLDER> to run the tests. Let me know if this helps or if you're still running into trouble with it

ijjk · 2019-10-05T11:11:00Z

Also, you can add the test under test/integration/client-navigation/test/rendering.js we have some other head related tests in there that this one sounds like would go along with

melanieseltzer · 2019-10-05T19:34:11Z

Thanks, @ijjk! That fix worked. Test has been added. Seems like there's an existing test for deduping but I created something a little more explicit for matching keys. Let me know if this is okay... wasn't sure if I should have just added matching keys to what was there already (instead of creating a new test case).

ijjk · 2019-10-05T19:39:11Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	16.3s	16.8s	⚠️ +436ms
nodeModulesSize	48.3 MB	48.3 MB	-13.8 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	945 B	-1 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	942 B	942 B	✓
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -368,7 +368,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.0.8-canary.5";
+var version = "9.0.8-canary.4";
 exports.version = version;
 var props = data.props,
     err = data.err,

Diff for main-HASH.module.js

@@ -425,7 +425,7 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.0.8-canary.5";
+const version = "9.0.8-canary.4";
 exports.version = version;
 const {
   props,

Diff for _error.js

@@ -303,7 +303,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Diff for _error.module.js

@@ -436,7 +436,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Diff for index.html

@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-d34a5c8437432dd29e59.js"
+        <script src="/_next/static/runtime/main-7f7a34a352f81fae8d77.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <script src="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -56,9 +56,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-d34a5c8437432dd29e59.js"
+        <script src="/_next/static/runtime/main-7f7a34a352f81fae8d77.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <script src="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -54,9 +54,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-d34a5c8437432dd29e59.js"
+        <script src="/_next/static/runtime/main-7f7a34a352f81fae8d77.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <script src="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	16.9s	17s	⚠️ +86ms
nodeModulesSize	48.3 MB	48.3 MB	-13.8 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_error.js	253 kB	254 kB	⚠️ +236 B
_error.js gzip	67.9 kB	68 kB	⚠️ +105 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	979 B	✓
index.js	254 kB	254 kB	⚠️ +236 B
index.js gzip	68.2 kB	68.3 kB	⚠️ +104 B
link.js	261 kB	262 kB	⚠️ +236 B
link.js gzip	70.3 kB	70.4 kB	⚠️ +102 B
routerDirect.js	255 kB	255 kB	⚠️ +236 B
routerDirect.js gzip	68.3 kB	68.4 kB	⚠️ +104 B
withRouter.js	254 kB	255 kB	⚠️ +236 B
withRouter.js gzip	68.4 kB	68.5 kB	⚠️ +104 B
Overall change	1.28 MB	1.28 MB	⚠️ +1.18 kB

Commit: a86dc5f

test/integration/client-navigation/pages/head-duplicate-default-keys.js

timneutkens

Awesome first PR @melanieseltzer! 💯🚀

ijjk · 2019-10-05T23:41:12Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	14.5s	14.7s	⚠️ +203ms
nodeModulesSize	48.3 MB	48.3 MB	-13.8 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	945 B	-1 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	942 B	942 B	✓
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -368,7 +368,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.0.8-canary.5";
+var version = "9.0.8-canary.4";
 exports.version = version;
 var props = data.props,
     err = data.err,

Diff for main-HASH.module.js

@@ -425,7 +425,7 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.0.8-canary.5";
+const version = "9.0.8-canary.4";
 exports.version = version;
 const {
   props,

Diff for _error.js

@@ -303,7 +303,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Diff for _error.module.js

@@ -436,7 +436,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Diff for index.html

@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-d34a5c8437432dd29e59.js"
+        <script src="/_next/static/runtime/main-7f7a34a352f81fae8d77.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <script src="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -56,9 +56,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-d34a5c8437432dd29e59.js"
+        <script src="/_next/static/runtime/main-7f7a34a352f81fae8d77.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <script src="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -54,9 +54,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-d34a5c8437432dd29e59.js"
+        <script src="/_next/static/runtime/main-7f7a34a352f81fae8d77.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e6f24f04f0ea80f64759.module.js"
+        <script src="/_next/static/runtime/main-f10d9867132b44eefaab.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	14.5s	14.7s	⚠️ +121ms
nodeModulesSize	48.3 MB	48.3 MB	-13.8 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_error.js	253 kB	254 kB	⚠️ +236 B
_error.js gzip	67.9 kB	68 kB	⚠️ +105 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	979 B	✓
index.js	254 kB	254 kB	⚠️ +236 B
index.js gzip	68.2 kB	68.3 kB	⚠️ +104 B
link.js	261 kB	262 kB	⚠️ +236 B
link.js gzip	70.3 kB	70.4 kB	⚠️ +102 B
routerDirect.js	255 kB	255 kB	⚠️ +236 B
routerDirect.js gzip	68.3 kB	68.4 kB	⚠️ +104 B
withRouter.js	254 kB	255 kB	⚠️ +236 B
withRouter.js gzip	68.4 kB	68.5 kB	⚠️ +104 B
Overall change	1.28 MB	1.28 MB	⚠️ +1.18 kB

Commit: e4f489b

ijjk · 2019-10-15T14:55:33Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	15.9s	15.8s	-30ms
nodeModulesSize	48.5 MB	48.5 MB	⚠️ +505 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	43.2 kB	✓
de003c3a9d30..0775.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for _error.js

@@ -303,7 +303,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Diff for _error.module.js

@@ -436,7 +436,12 @@ function unique() {
       if (keys.has(h.key)) return false;
       keys.add(h.key);
       return true;
-    }
+    } // If custom meta tag has been added the key will be prepended with `.$`, we can
+    // check for this and dedupe in favor of the custom one, so the default
+    // is not rendered as well
+
+
+    if (keys.has(".$".concat(h.key))) return false;
 
     switch (h.type) {
       case 'title':

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
buildDuration	16.5s	16.1s	-369ms
nodeModulesSize	48.5 MB	48.5 MB	⚠️ +505 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	43.2 kB	✓
de003c3a9d30..0775.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12.1 kB	⚠️ +38 B
_error.js gzip	4.73 kB	4.75 kB	⚠️ +12 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.9 kB	⚠️ +38 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	⚠️ +38 B
_error.module.js gzip	8.59 kB	8.61 kB	⚠️ +14 B
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	⚠️ +38 B

Client Build Manifests

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	melanieseltzer/next.js dedupe-tags	Change
_error.js	254 kB	254 kB	⚠️ +236 B
_error.js gzip	68 kB	68.1 kB	⚠️ +105 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	979 B	✓
index.js	254 kB	255 kB	⚠️ +236 B
index.js gzip	68.4 kB	68.5 kB	⚠️ +104 B
link.js	262 kB	262 kB	⚠️ +236 B
link.js gzip	70.4 kB	70.5 kB	⚠️ +101 B
routerDirect.js	255 kB	255 kB	⚠️ +236 B
routerDirect.js gzip	68.4 kB	68.5 kB	⚠️ +107 B
withRouter.js	255 kB	255 kB	⚠️ +236 B
withRouter.js gzip	68.5 kB	68.6 kB	⚠️ +104 B
Overall change	1.28 MB	1.29 MB	⚠️ +1.18 kB

Commit: f045e31

melanieseltzer · 2019-10-15T15:11:01Z

Hi @timneutkens Is there anything else I need to do to have this merged? :)

Timer

Nothing to change, this is great! Sorry for the delay.

sheerun · 2019-11-05T09:20:28Z

test/integration/client-navigation/test/rendering.js

@@ -82,6 +82,16 @@ export default function (render, fetch) {
      )
    })

+    test('header helper dedupes tags with the same key as the default', async () => {
+      const html = await render('/head')


You render wrong page

This adjusts a test added in vercel#8960 to render the correct page.

This adjusts a test added in #8960 to render the correct page.

Dedupe meta tag in favor of custom tag defined in _app

6e2925d

melanieseltzer requested review from ijjk, lfades, Timer and timneutkens as code owners October 4, 2019 07:00

Merge branch 'canary' into dedupe-tags

7c1d7ce

Add test

a86dc5f

sdornan reviewed Oct 5, 2019

View reviewed changes

test/integration/client-navigation/pages/head-duplicate-default-keys.js Outdated Show resolved Hide resolved

Fix comments

e4f489b

timneutkens approved these changes Oct 5, 2019

View reviewed changes

melanieseltzer added 2 commits October 5, 2019 16:56

Merge branch 'canary' into dedupe-tags

bc19248

Merge branch 'canary' into dedupe-tags

f045e31

Timer added this to the 9.1.2 milestone Oct 18, 2019

Timer approved these changes Oct 18, 2019

View reviewed changes

Timer added ready to land labels Oct 18, 2019

Timer mentioned this pull request Oct 18, 2019

Duplicate viewport tag #8654

Closed

Merge branch 'canary' into dedupe-tags

5f6980c

Timer merged commit c650ed9 into vercel:canary Oct 18, 2019

Timer mentioned this pull request Oct 18, 2019

next/head rendering custom components server-side but not client-side #9126

Closed

sheerun mentioned this pull request Nov 5, 2019

Fix deduplicating dynamic (array) meta tags #9315

Merged

sheerun reviewed Nov 5, 2019

View reviewed changes

Timer added a commit to Timer/next.js that referenced this pull request Nov 15, 2019

Adjust Client Nav Test

4b27d54

This adjusts a test added in vercel#8960 to render the correct page.

Timer mentioned this pull request Nov 15, 2019

Adjust Client Nav Test #9422

Merged

Timer added a commit that referenced this pull request Nov 15, 2019

Adjust Client Nav Test (#9422)

2f16a86

This adjusts a test added in #8960 to render the correct page.

This was referenced Nov 19, 2019

[Snyk] Upgrade next from 9.1.2 to 9.1.3 ndom91/newtelco-next-maintenance-mgmt#10

Merged

[Snyk] Upgrade next from 9.0.4 to 9.1.3 ajesse11x/now-examples#17

Open

Manc mentioned this pull request Dec 20, 2019

Fix/improve test for deduplication of tags with same key in Head #9793

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dedupe meta tags #8960

Dedupe meta tags #8960

melanieseltzer commented Oct 4, 2019 •

edited

Loading

timneutkens commented Oct 4, 2019

melanieseltzer commented Oct 4, 2019

ijjk commented Oct 4, 2019

Diffs

ijjk commented Oct 5, 2019

ijjk commented Oct 5, 2019

melanieseltzer commented Oct 5, 2019

ijjk commented Oct 5, 2019

Diffs

timneutkens left a comment

ijjk commented Oct 5, 2019

Diffs

ijjk commented Oct 15, 2019

Diffs

melanieseltzer commented Oct 15, 2019

Timer left a comment

sheerun Nov 5, 2019

Dedupe meta tags #8960

Dedupe meta tags #8960

Conversation

melanieseltzer commented Oct 4, 2019 • edited Loading

timneutkens commented Oct 4, 2019

melanieseltzer commented Oct 4, 2019

ijjk commented Oct 4, 2019

Stats from current PR

Diffs

ijjk commented Oct 5, 2019

ijjk commented Oct 5, 2019

melanieseltzer commented Oct 5, 2019

ijjk commented Oct 5, 2019

Stats from current PR

Diffs

timneutkens left a comment

Choose a reason for hiding this comment

ijjk commented Oct 5, 2019

Stats from current PR

Diffs

ijjk commented Oct 15, 2019

Stats from current PR

Diffs

melanieseltzer commented Oct 15, 2019

Timer left a comment

Choose a reason for hiding this comment

sheerun Nov 5, 2019

Choose a reason for hiding this comment

melanieseltzer commented Oct 4, 2019 •

edited

Loading