[with-typescript] Updated TypeScript example to use API routes #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next.js 9.0.0 has been out for a while, which supports API routes, but the examples were never updated to make use of it. This PR adds a simple example of an API route which also makes use of dynamic routing. A simple `fetch()` wrapper is also added for example purposes, and the pages structure have also been updated to dynamic routing.
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: c8fdb91 |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: b704d1d |
lfades
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Hi @resir014 thank you for the PR, this changes introduces more complexity into the example but I do like it as a way of showing API types, which is the point of the example.
I updated the link for the dynamic route and it should be ready to go 👍
|
Thanks @lfades! Would you mind if I work on another PR splitting this example into two, one for the most basic TS example for a quickstart, and the other for TS + API routes? I can work on it sometime next week. |
|
@resir014 It's good right now, way better than having it separated, thank you 👍 |
This was referenced Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.js 9.0.0 has been out for a while, which supports API routes, but
the examples were never updated to make use of it. This PR adds a simple
example of an API route which also makes use of dynamic routing.
A simple
fetch()wrapper is also added for example purposes, and thepages structure have also been refactored to dynamic routing.