Allow port to be set in the asset tags for theme previews.

[TruRooms]

✌️

/cc @zendesk/vegemite

Description

While setting a non standard port, scripts for the template were still getting injected with the standard port. Updated to respect the :port option when it is set using the standard options set and inject the appropriate script/style tags into the doc head.

Tasks

• [ x] Include comments/inline docs where appropriate
• [ x] Write tests

References

Risks

• [medium] Does it work on windows? Unable to verify
• [low] Does it work in the different products (Support, Chat)? Only for the form preview
• [low] Are there any performance implications? Optional port change should not effect performance.
• [medium] Any security risks? Allowing script tag to follow the port set from the CLI.
• [low] What features does this touch? The template live preview server.

[augustocravosilva]

Thanks for the PR!

Looks like there's still 2 hardcoded references to port '4567', would you be able to update that too?

zendesk_apps_tools/lib/zendesk_apps_tools/theming/common.rb

Line 12 in 4604c68

"http://localhost:4567/guide/#{path_parts.join('/')}"

zendesk_apps_tools/lib/zendesk_apps_tools/theme.rb

Line 145 in 4604c68

server.use Rack::LiveReload, live_reload_port: 4567 if options[:livereload]

[Romuloux]

@augustocravosilva Good catch, references have been updated.