This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Extend link CLI command to support multiple dependencies #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using link command - using init command specifying the --link option
facuspagnuolo
approved these changes
Aug 28, 2018
| await initLib({ name, version, force }) | ||
| } else { | ||
| const { link: libNameVersion, install: installLib } = options | ||
| await init({ name, version, libNameVersion, installLib, force }) | ||
| const libs = link ? link.split(',') : [] |
There was a problem hiding this comment.
we could use utils/input#parseArgs I think
| @@ -7,7 +7,7 @@ import { Contracts, Logger } from 'zos-lib'; | |||
| import add from '../../src/scripts/add.js'; | |||
| import push from '../../src/scripts/push.js'; | |||
| import createProxy from '../../src/scripts/create.js'; | |||
| import linkLib from '../../src/scripts/link.js'; | |||
| import linkLibs from '../../src/scripts/link.js'; | |||
There was a problem hiding this comment.
I would stick to just link
There was a problem hiding this comment.
Agree. Let's leave this up until we do the stdlib naming refactor.
spalladino
pushed a commit
that referenced
this pull request
Sep 24, 2018
* Implement linking multiple dependencies - using link command - using init command specifying the --link option * Fix in conditional
spalladino
pushed a commit
that referenced
this pull request
Sep 24, 2018
* Implement linking multiple dependencies - using link command - using init command specifying the --link option * Fix in conditional
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example usage:
or